Revert perf-regression Known-issue note (confirmed false alarm)#198
Merged
Conversation
The ~2.4x Insert_with_audit alert (#195) was CI measurement noise, not a real regression: #192 changed none of that benchmark's runtime deps (SQLite/net10/ EF Core 10.0.0 — the EF9/SqlClient7 bumps were integration-test-only), and a local run measures ~18.5 ms at BatchSize 50 (faster than the 21 ms baseline, vs the anomalous 49.9 ms CI outlier). #195 closed; restore the empty Unreleased placeholder. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes the previously added “Known issues” performance-regression note from the changelog after the related benchmark alert was confirmed to be CI measurement noise, returning the [Unreleased] section to an explicit empty placeholder.
Changes:
- Reverted the Unreleased → Known issues entry describing a possible
Insert_with_auditslowdown. - Restored an explicit empty-placeholder line under [Unreleased] to indicate no pending notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #195 (now closed as a false alarm) and #196 (which added the note).
The
Insert_with_auditbenchmark alert on #192 was CI measurement noise, not a regression:--job short): BatchSize 50 = 18.5 ms (StdDev 0.69), faster than the 21 ms CI baseline and far from the 49.9 ms anomalous CI reading that fired the alert.Restores the empty
[Unreleased]placeholder. Docs-only.