Removed Character Sanitization When Searching #879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled character sanitization when searching as this was encoding characters (&,<,>"), which was resulting in options not being retrieved.
After trying to see the demo for this project I noticed that the link leads to a 404 page. I found the updated link in [Choices-js#957] and this commit updates the README to link to the proper URL. [Choices-js#957]: Choices-js#957
Fix broken demo link in README.md
…h to hardcoded path
… objects to resolve dependency cycles
…ompatibility, switch IE to Edge for browser testing (IE web driver no longer pre-installed on runner)
… dependencies - replace deprecated eslint-loader
…ave Puppeteer diff image even if pixelmatch throws error, update Chrome snapshot
Update dependencies, refactor to remove dependency cycles, fix GitHub Action workflows
Fix typo in README.md s/withing/within
* Update README.md * Update README.md Switch to the Choices-js organization link. Co-authored-by: Matt Triff <[email protected]>
…ces-js#976) * replace / by * * replace / by * * add leading zero * add leading zero
* Documentation of input type terms Add a table with documentation of HTML5 input tag correspondence to terms used in Choices documentation * Update README.md Clean up typos, simplify table and use MDN for reference links Co-authored-by: Matt Triff <[email protected]>
De-emphasize call for maintainers.
Switch to dart-sass, fix npm audit issues, add stylelint
HTML uses `>` to encode `>` characters.
Fix Sanitization of > Characters
* Enhance inputCloned text input with type and name Safari will display a contact autocomplete on every text input which `name` attribute contains "*name*" or does not have any `name` attribute. Adding a fine tuned `name`attribute to the input should prevent that. Plus, input type="search" seems more suited to the field intent (https://developer.mozilla.org/fr/docs/Web/HTML/Element/Input/search). * Adapt inputCloned related test
feat: Introduce allowHTML option to allow people to disable injecting HTML into choices.
fix: Add typings to published files
Disabled character sanitization when searching as this was encoding characters (&,<,>"), which was resulting in options not being retrieved.
10 tasks
|
Thanks for this! Looks like I made a mess of your branch when I added some changes (sorry). I'll merge this under #990 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabled character sanitization when searching as this was encoding characters (&,<,>"), which was resulting in options not being retrieved.
Screenshots (if appropriate)
Types of changes
Checklist