Always hide remove button if no value is selected #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the remove item X button is not hidden when there is no selection made from the dropdown. This is not as usable, since there's no item to clear, hence an effective noop. The condition I saw seeing this issue arise is in single selects with a placeholder value, a selection has been made, and then cleared: the button HTML remains. To fix, add some styles to hide the button if the select doesn't have a value selected, in this case keying off of it's parents `data-value` property. fixes Choices-js#684
bronzehedwick
force-pushed
the
hide-remove-button
branch
from
f7ccae2 to
363b3b4
Compare
|
@jshjohnson Not sure why the selenium tests are failing, the error messages are pretty vague. Do you have any insight here? Thanks. |
I wouldn't worry about that - Github has made some changes to the macOS-latest image which is causing problems with CI 👍 |
jshjohnson
approved these changes
Nov 12, 2019
|
Thanks @bronzehedwick 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, the remove item X button is not hidden when there is no
selection made from the dropdown. This is not as usable, since there's
no item to clear, hence an effective noop.
The condition I saw seeing this issue arise is in single selects with
a placeholder value, a selection has been made, and then cleared: the
button HTML remains.
To fix, add some styles to hide the button if the select doesn't have a
value selected, in this case keying off of it's parents
data-valueproperty.
fixes #684
Screenshots (if appropriate)
Types of changes
Checklist