-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing type definitions + rename sortFn #734
Conversation
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 66.18% 66.46% +0.28%
==========================================
Files 23 22 -1
Lines 1307 1309 +2
==========================================
+ Hits 865 870 +5
+ Misses 442 439 -3
Continue to review full report at Codecov.
|
@jshjohnson can we rename And also removing completely all sort related settings - I mean, if I would like to do similar approach to |
That's also can be done in a way of deprecation - I mean, undocument old settings now, but still support it until next major. |
BTW, my |
Hmm, hard to say without seeing your implementation. Do you mind if I keep this as is for the time being and if we think we need to update it after your search PR, we can? |
Description
sortFn
tosorter
to be consistent with other functions passed via configitemComparer
tovalueComparer
to be clearer about what the function actually doesScreenshots (if appropriate)
Types of changes
Checklist