Add support for standard-compliant placeholder option #617
Conversation
| return ( | ||
| this.element.querySelector('option[value=""]') || | ||
| this.element.querySelector('option[placeholder]') | ||
| ); |
There was a problem hiding this comment.
Would you mind just adding a comment here explaining why both are supported please 👍
There was a problem hiding this comment.
Would you also mind incrementing a minor version please (not major - ignore my original comment )
There was a problem hiding this comment.
done (as a separate commit, as updating the build file for the new version also included other changes which were not yet in it).
There was a problem hiding this comment.
@jshjohnson @stof That should be done in the same .querySelector('option[value=""], option[placeholder]')
There was a problem hiding this comment.
@tinovyatkin no, that's not the same. Your proposal would use whatever is found first. My code is using the standard way if it is there (and so if you define both, the standard way wins)
There was a problem hiding this comment.
@jshjohnson
Ugh, if somebody defines both, one with invalid, but very implicit and documented (by this library) attribute placeholder and second one just with empty value and empty value starts winning - I think it's a breaking change.
stof
force-pushed
the
standard_placeholder
branch
from
d6dbecf to
6e5d324
Compare
* Add support for standard-compliant placeholder option * Bump version and rebuild files
Description
Fixes #447
Replaces #474. The implementation is almost the same. But my PR preserves backward compatibility by using
<option placeholder>as a fallback when there is no<option value="">.Types of changes
Checklist: