Resolve issue #607 with utils::calcWidthOfInput() #608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change modifies the
utils::calcWidthOfInput()
function to transferpaddingLeft
andpaddingRight
from the source input to the test input explicitly, rather than relying on the shorthand propertypadding
.Motivation and Context
See #607 - shorthand CSS properties are not supported in
window.getComputedStyle()
except in Chrome (due to a departure from CSS spec in favor of usability).This results in width being undercounted in Firefox for inputs that use padding.
How Has This Been Tested?
Tested in Chrome and Firefox to confirm padding is now accounted for correctly in both.
Types of changes
Checklist: