Fix tab and esc keys handling

[zoglo]

Description

• Fixes Accessibility Bug: Filter + Search Dropdown Field Traps Focus When Using <Shift>+<Tab> #1234
• Fixes #1209 (comment)

This PR fixes the weird behavior that people have when search has been disabled and you are trying to tab through.

Keys like tab for keyboard accessibility have not been taken into account at all, rendering keyboard navigation impossible in the current version. (Especially trying to navigate back as well when a search exists).

The dropdown stays open due to the following line not taking into account the typical behavior of Tab (focusing out) or Escape.
https://github.com/Choices-js/Choices/blob/a127f82755e85f326d929054359370a117fa173c/src/scripts/choices.ts#L1606-#L1623

Screenshots (if appropriate)

Types of changes

• Chore (tooling change or documentation change)
• Refactor (non-breaking change which maintains existing functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• My code follows the code style of this project.
• I have added new tests for the bug I fixed/the new feature I added.
• I have modified existing tests for the bug I fixed/the new feature I added.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[Xon]

This sadly makes #1230 much more obvious the direction key handling is buggy :(

[zoglo]

This sadly makes #1230 much more obvious the direction key handling is buggy :(

Hmm, you mean with shift + tab, right?
Should we open a new issue for that one, especially accessible wise?

There's a few more things I noticed but didn't have the time to find a proper solution for right now

[zoglo]

We could continue this in the mentioned issue as well, especially since the handling could be improved upon and there's more to handle such as shift + tab at the same time not focusing into an existing serach - I noted it down

[Xon]

A new issue to track it would be best

[Xon]

@zoglo I've opened the #1242 which appears to fix #1230
Can you see if it fixes other issues you've observed around tab-handling?

[zoglo]

@zoglo I've opened the 1242 which appears to fix 1230 Can you see if it fixes other issues you've observed around tab-handling?

Will check tmrw after I wake up👍