Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from apicache to apicache-plus to unblock nodejs support #2884

Closed
wants to merge 1 commit into from

Conversation

rigelk
Copy link
Collaborator

@rigelk rigelk commented Jun 18, 2020

apicache seems loosely maintained, especially regarding the support for nodejs 13 & 14. Hopefully, someone took care of the package and published it as apicache-plus, retaining retro-compatibility and adding the lacking engine support.

fixes #2700

@Chocobozzz
Copy link
Owner

apicache-plus is not used enough. There is not a community that can help us to check releases/bugs and security issues.

There is a WIP for node 13 support: kwhitley/apicache#212

We can also use another cache middleware, that is widely used.

@Chocobozzz Chocobozzz closed this Jun 22, 2020
@rigelk
Copy link
Collaborator Author

rigelk commented Sep 28, 2020

@Chocobozzz would using the branch/commit in the PR you linked be an acceptable temp workwround?

@rigelk
Copy link
Collaborator Author

rigelk commented Nov 20, 2020

There is not a community that can help us to check releases/bugs and security issues.

@Chocobozzz I'm afraid the maintainer of apicache is not interested in continuing it or its refactoring: kwhitley/apicache#226 (comment)

Of note, Redis support was not the primary target of apicache either, and any v2 would drop support for it in favor of a pluggable implementation.

If we are aiming for proper reactivity/support, I'm not sure apicache is so satisfactory.

@Chocobozzz
Copy link
Owner

I'm waiting for the merge of kwhitley/apicache#228

@rigelk
Copy link
Collaborator Author

rigelk commented Nov 21, 2020

Ah great! I hadn't seen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PeerTube 2.1.1 incompatibility with Node.js >=13
2 participants