Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to override http client for oauth calls #137

Open
dmah42 opened this issue May 2, 2016 · 0 comments
Open

unable to override http client for oauth calls #137

dmah42 opened this issue May 2, 2016 · 0 comments

Comments

@dmah42
Copy link

dmah42 commented May 2, 2016

Using anaconda within appengine fails as AuthorizationURL and GetCredentials use http.DefaultClient. As per the documentation, appengine fetches need to use the urlfetch package. It's possible to override the client for the API object, but this isn't used for these calls.

Either these methods should be on the API, which I think is tricky as it requires passing around the API to the callback, or the client could be passed in to the methods, which is unfortunate.

If there's another way to handle this, with the existing code or with a patch, i'd like to hear it.
dmah42 added a commit to dmah42/anaconda that referenced this issue May 12, 2016
@dmah42
Allows overriding of HTTP clients for oauth calls.
ae9613b 
Fixes ChimeraCoder#137.

This is backwards compatible, although it is a little non-go-like.
There could also be a second version of each of these methods that takes
a *http.Client explicitly.
@dmah42 dmah42 mentioned this issue May 12, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmah42