Skip to content

Pin SQLite native dependency to secure SQLitePCLRaw bundle - #9993

Merged
glen-84 merged 1 commit into
mainfrom
gai/pin-sqlitepclraw-secure-bundle
Jun 26, 2026
Merged

glen-84 merged 1 commit into
mainfrom
gai/pin-sqlitepclraw-secure-bundle

Conversation

@glen-84

@glen-84 glen-84 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Centralize the SQLite native dependency for test projects on SQLitePCLRaw.bundle_e_sqlite3 3.0.3 in Directory.Packages.props, replacing the previous sqlite-net-pcl + SQLitePCLRaw.bundle_green packages.
  • StrawberryShake test projects reference the bundle directly so the e_sqlite3 provider auto-registers for Microsoft.Data.Sqlite.Core.
  • EF Core / Data / Mocha test projects explicitly pin the bundle to override the high-severity SQLitePCLRaw.lib.e_sqlite3 advisory (GHSA-2m69-gcr7-jv3q) pulled transitively via Microsoft.EntityFrameworkCore.Sqlite.

Test plan

  • dotnet list src/All.slnx package --vulnerable reports no vulnerable packages.
  • SQLite-backed tests pass: StrawberryShake Persistence.SQLite, HotChocolate.Data.Sorting.SqlLite, and Mocha.EntityFrameworkCore.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the repo’s test-project SQLite dependency strategy to ensure a secure, consistent native SQLite provider by standardizing on SQLitePCLRaw.bundle_e_sqlite3 (v3.0.3) via central package management, replacing the prior sqlite-net-pcl + SQLitePCLRaw.bundle_green approach.

Changes:

  • Replaced sqlite-net-pcl and SQLitePCLRaw.bundle_green references in StrawberryShake test projects with SQLitePCLRaw.bundle_e_sqlite3.
  • Added explicit SQLitePCLRaw.bundle_e_sqlite3 references to EF Core/Mocha/HotChocolate/GreenDonut test projects to override vulnerable transitive SQLite native dependencies.
  • Centralized the bundle version in src/Directory.Packages.props (3.0.3) and removed the previous central versions.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/StrawberryShake/CodeGeneration/test/CodeGeneration.Razor.Tests/StrawberryShake.CodeGeneration.Razor.Tests.csproj Switches SQLite test dependency to SQLitePCLRaw.bundle_e_sqlite3.
src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/StrawberryShake.CodeGeneration.CSharp.Tests.csproj Switches SQLite test dependency to SQLitePCLRaw.bundle_e_sqlite3.
src/StrawberryShake/Client/test/Persistence.SQLite.Tests/StrawberryShake.Persistence.SQLite.Tests.csproj Switches SQLite test dependency to SQLitePCLRaw.bundle_e_sqlite3.
src/Mocha/test/Mocha.Tests/Mocha.Tests.csproj Adds explicit SQLitePCLRaw.bundle_e_sqlite3 pin alongside EF Core Sqlite for security.
src/Mocha/test/Mocha.EntityFrameworkCore.Tests/Mocha.EntityFrameworkCore.Tests.csproj Adds explicit SQLitePCLRaw.bundle_e_sqlite3 pin alongside EF Core Sqlite for security.
src/HotChocolate/Data/test/Data.Sorting.SqlLite.Tests/HotChocolate.Data.Sorting.SqlLite.Tests.csproj Adds explicit SQLitePCLRaw.bundle_e_sqlite3 pin alongside EF Core Sqlite for security.
src/HotChocolate/Data/test/Data.Projections.SqlServer.Tests/HotChocolate.Data.Projections.SqlServer.Tests.csproj Adds explicit SQLitePCLRaw.bundle_e_sqlite3 pin alongside EF Core Sqlite for security.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/HotChocolate.Data.Filters.SqlServer.Tests.csproj Adds explicit SQLitePCLRaw.bundle_e_sqlite3 pin alongside EF Core Sqlite for security.
src/HotChocolate/Data/test/Data.EntityFramework.Tests/HotChocolate.Data.EntityFramework.Tests.csproj Adds explicit SQLitePCLRaw.bundle_e_sqlite3 pin alongside EF Core Sqlite for security.
src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/GreenDonut.Data.EntityFramework.Tests.csproj Adds explicit SQLitePCLRaw.bundle_e_sqlite3 pin alongside EF Core Sqlite for security.
src/Directory.Packages.props Centralizes SQLitePCLRaw.bundle_e_sqlite3 version (3.0.3) and removes prior SQLite package versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84
glen-84 merged commit e5c57c4 into main Jun 26, 2026
147 checks passed
@glen-84
glen-84 deleted the gai/pin-sqlitepclraw-secure-bundle branch June 26, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants