Skip to content

Exclude test and benchmark files from patch coverage #9992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glen-84 merged 3 commits into from
Jun 26, 2026
Merged

Exclude test and benchmark files from patch coverage #9992

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37a123d
Exclude test and benchmark files from patch coverage
glen-84 Jun 26, 2026
8b23b2f
Exclude test files from project coverage total
glen-84 Jun 26, 2026
9693e95
Rename `IsTestPath` to `IsProductionPath`
glen-84 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions .github/scripts/patch-coverage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,21 @@
// 2. Parse cobertura: absolute path -> (line -> hits). Merge partial-class duplicates by max hits.
var coverage = ParseCobertura(coberturaPath);

// Whole-project line coverage (every instrumented file in the report).
var projValid = coverage.Sum(f => f.Value.Count);
var projCovered = coverage.Sum(f => f.Value.Values.Count(h => h > 0));
// Whole-project line coverage (production files only; test/benchmark sources are excluded).
var prodFiles = coverage.Where(f => IsProductionPath(f.Key)).ToList();
var projValid = prodFiles.Sum(f => f.Value.Count);
var projCovered = prodFiles.Sum(f => f.Value.Values.Count(h => h > 0));
var projPct = projValid == 0 ? 100.0 : 100.0 * projCovered / projValid;

// 3. Intersect per file. A changed line counts only if it appears in coverage (executable).
var rows = new List<FileRow>();
foreach (var (path, lines) in changed.OrderBy(x => x.Key, StringComparer.Ordinal))
{
if (!IsProductionPath(path))
{
continue; // patch coverage measures production code, not test/benchmark sources
}

var hits = Match(coverage, path);
if (hits is null)
{
Expand Down Expand Up @@ -349,6 +355,16 @@ static string BuildJson(string sha, List<FileRow> withMisses)
return b.ToString();
}

static bool IsProductionPath(string path)
{
// Exclude test and benchmark sources; everything else counts as production.
var p = "/" + path.Replace('\\', '/') + "/";
return !(p.Contains("/test/", StringComparison.OrdinalIgnoreCase)
|| p.Contains("/tests/", StringComparison.OrdinalIgnoreCase)
|| p.Contains("/benchmark/", StringComparison.OrdinalIgnoreCase)
|| p.Contains("/benchmarks/", StringComparison.OrdinalIgnoreCase));
}

static string Sha256Hex(string value)
{
var bytes = System.Security.Cryptography.SHA256.HashData(Encoding.UTF8.GetBytes(value));
Expand Down
Loading