Repository navigation
Reference net11-bundled packages only on net8.0/net9.0/net10.0 - #9951
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts project-level PackageReference entries so that packages now bundled by the .NET 11 shared framework are only referenced on TFMs that still require them, preventing NU1510 from failing single-target net11.0 builds under TreatWarningsAsErrors.
Changes:
- Conditioned
Microsoft.Extensions.*package references to only apply onnet8.0/net9.0/net10.0, dropping them fornet11.0. - Kept existing per-TFM handling patterns consistent with other framework-bundled packages (e.g.,
System.IO.Pipelines,System.Net.ServerSentEvents).
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/StrawberryShake/Client/src/Transport.WebSockets/StrawberryShake.Transport.WebSockets.csproj | Condition Microsoft.Extensions.Options reference to net8/9/10 only. |
| src/StrawberryShake/Client/src/Transport.Http/StrawberryShake.Transport.Http.csproj | Move Microsoft.Extensions.DependencyInjection.Abstractions into a net8/9/10-only ItemGroup. |
| src/StrawberryShake/Client/src/Core/StrawberryShake.Core.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/Mocha/src/Mocha/Mocha.csproj | Condition Hosting.Abstractions, Options, Primitives references to net8/9/10 only. |
| src/Mocha/src/Mocha.Threading/Mocha.Threading.csproj | Condition Microsoft.Extensions.Logging.Abstractions reference to net8/9/10 only. |
| src/Mocha/src/Mocha.Mediator/Mocha.Mediator.csproj | Move DependencyInjection.Abstractions and Options into a net8/9/10-only ItemGroup. |
| src/Mocha/src/Mocha.Abstractions/Mocha.Abstractions.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/HotChocolate/Utilities/src/Utilities/HotChocolate.Utilities.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/HotChocolate/PersistedOperations/src/PersistedOperations.Pipeline/HotChocolate.PersistedOperations.Pipeline.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/HotChocolate/Fusion/src/Fusion.Execution/HotChocolate.Fusion.Execution.csproj | Move Microsoft.Extensions.DependencyInjection.Abstractions into a net8/9/10-only ItemGroup. |
| src/HotChocolate/Fusion/src/Fusion.Execution.Types/HotChocolate.Fusion.Execution.Types.csproj | Move Microsoft.Extensions.DependencyInjection.Abstractions into a net8/9/10-only ItemGroup. |
| src/HotChocolate/Core/src/Validation/HotChocolate.Validation.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/HotChocolate/Core/src/Types/HotChocolate.Types.csproj | Condition Microsoft.Extensions.Options reference to net8/9/10 only. |
| src/HotChocolate/Core/src/Subscriptions.Serializers.Newtonsoft/HotChocolate.Subscriptions.Serializers.Newtonsoft.csproj | Move Microsoft.Extensions.DependencyInjection.Abstractions into a net8/9/10-only ItemGroup. |
| src/HotChocolate/Core/src/Subscriptions.Redis/HotChocolate.Subscriptions.Redis.csproj | Move Microsoft.Extensions.DependencyInjection.Abstractions into a net8/9/10-only ItemGroup. |
| src/HotChocolate/Core/src/Subscriptions.InMemory/HotChocolate.Subscriptions.InMemory.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/HotChocolate/Core/src/Execution.Pipeline/HotChocolate.Execution.Pipeline.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/HotChocolate/Core/src/Execution.Configuration.Abstractions/HotChocolate.Execution.Configuration.Abstractions.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/HotChocolate/Core/src/Execution.Abstractions/HotChocolate.Execution.Abstractions.csproj | Condition Microsoft.Extensions.DependencyInjection.Abstractions reference to net8/9/10 only. |
| src/HotChocolate/Caching/src/Caching.Core/HotChocolate.Caching.Core.csproj | Condition Microsoft.Extensions.Options reference to net8/9/10 only. |
| src/GreenDonut/src/GreenDonut/GreenDonut.csproj | Move Microsoft.Extensions.DependencyInjection.Abstractions into a net8/9/10-only ItemGroup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the Show a code coverage summary of the most impacted files.
Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
This was referenced Jun 22, 2026
This was referenced Jul 2, 2026
Closed
Closed
This was referenced Jul 7, 2026
This was referenced Jul 14, 2026
This was referenced Jul 23, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.Extensions.*packages (DependencyInjection.Abstractions,Options,Primitives,Logging.Abstractions,Hosting.Abstractions) are now part of the .NET 11 shared framework. When a project is built single-target net11 (e.g. the Nitro CLI AOT release publish), NuGet package pruning raisesNU1510for the now-redundant direct references, failing the build underTreatWarningsAsErrors.net8.0/net9.0/net10.0(the TFMs that still need them) so they are dropped on net11, where the framework provides them. The normal multi-target build was unaffected because pruning only triggers when it applies to every target.System.Net.ServerSentEventsandSystem.IO.Pipelineshandling.Test plan
NU1510).NU1510remaining.