Skip to content

Serialize sbyte values as JSON numbers in StrawberryShake #9827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glen-84 merged 3 commits into from
Jun 3, 2026
Merged

Serialize sbyte values as JSON numbers in StrawberryShake #9827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3560751
Serialize sbyte values as JSON numbers in StrawberryShake
glen-84 Jun 3, 2026
6884b84
Merge branch 'main' into gai/sbyte-json-number-serialization
glen-84 Jun 3, 2026
9d5b178
Merge branch 'main' into gai/sbyte-json-number-serialization
glen-84 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/StrawberryShake/Client/src/Core/Json/JsonSerializationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ public static void WriteValue(object? value, Utf8JsonWriter writer)
writer.WriteStringValue(s);
break;

case sbyte sb:
writer.WriteNumberValue(sb);
break;

case byte b:
writer.WriteNumberValue(b);
break;
Expand Down
1 change: 1 addition & 0 deletions src/StrawberryShake/Client/test/Core.Tests/Json/JsonOperationRequestSerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public void Serialize_Request_With_Extensions()
operationRequest.Extensions.Add(nameof(String), "def");
operationRequest.Extensions.Add("null", null);

operationRequest.Extensions.Add(nameof(SByte), (sbyte)123);
operationRequest.Extensions.Add(nameof(Byte), (byte)123);
operationRequest.Extensions.Add(nameof(Int16), (short)123);
operationRequest.Extensions.Add(nameof(UInt16), (ushort)123);
Expand Down
8 changes: 8 additions & 0 deletions src/StrawberryShake/Client/test/Core.Tests/Json/JsonSerializationHelperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ public void ReadScalarList()
item => Assert.Equal(4, Assert.IsType<long>(item)));
}

[Fact]
public void WriteSByteAsNumber()
{
var json = JsonSerializationHelper.WriteValue((sbyte)2);

Assert.Equal("2", json);
}

[Fact]
public void ReadNestedScalarList()
{
Expand Down
1 change: 1 addition & 0 deletions .../__snapshots__/JsonOperationRequestSerializerTests.Serialize_Request_With_Extensions.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"extensions": {
"String": "def",
"null": null,
"SByte": 123,
"Byte": 123,
"Int16": 123,
"UInt16": 123,
Expand Down
Loading