Skip to content

[Fusion] Remove locations from errors raised during subgraph execution #9729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobias-tengler merged 1 commit into from
May 18, 2026
Merged

[Fusion] Remove locations from errors raised during subgraph execution #9729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,15 +217,9 @@ public void FinalizePocketedErrors(CompositeResultElement resultData)

if (parentResult.ValueKind is JsonValueKind.Undefined)
{
var parentSelection = parentResult.Selection;
var promotedError = ErrorBuilder.FromError(error)
.SetPath(parentPath);

if (parentSelection is not null)
{
promotedError = promotedError.AddLocation(parentSelection.SyntaxNodes[0].Node);
}

_store.AddError(_errorHandler.Handle(promotedError.Build()));
parentResult.SetNullValue();
_store.RemovePocketedErrorsInSubtree(parentPath);
Expand Down Expand Up @@ -431,7 +425,6 @@ private bool ApplyFieldError(
{
var errorWithPath = ErrorBuilder.FromError(error)
.SetPath(path)
.AddLocation(selection.SyntaxNodes[0].Node)
.Build();
errorWithPath = _errorHandler.Handle(errorWithPath);

Expand Down Expand Up @@ -498,7 +491,6 @@ private bool TryCompleteValue(
var path = target.CompactPath.ToPath(target.Operation);
error = ErrorBuilder.FromError(errorFromPath)
.SetPath(path)
.AddLocation(selection.SyntaxNodes[0].Node)
.Build();
}
else
Expand All @@ -508,7 +500,6 @@ private bool TryCompleteValue(
.SetMessage("Cannot return null for non-nullable field.")
.SetCode(ErrorCodes.Execution.NonNullViolation)
.SetPath(path)
.AddLocation(selection.SyntaxNodes[0].Node)
.Build();
}

Expand Down Expand Up @@ -545,7 +536,6 @@ private bool TryCompleteValue(
{
var errorWithPath = ErrorBuilder.FromError(errorFromPath)
.SetPath(target.Path)
.AddLocation(selection.SyntaxNodes[0].Node)
.Build();
errorWithPath = _errorHandler.Handle(errorWithPath);

Expand Down Expand Up @@ -636,7 +626,6 @@ private bool TryCompleteList(
{
var errorWithPath = ErrorBuilder.FromError(error)
.SetPath(target.CompactPath.ToPath(target.Operation, i))
.AddLocation(selection.SyntaxNodes[0].Node)
.Build();
errorWithPath = _errorHandler.Handle(errorWithPath);

Expand Down
Loading