Skip to content

[Nitro CLI] Refine fusion publish for migration#9617

Merged
tobias-tengler merged 3 commits intomainfrom
tte/migration-refinements
Apr 29, 2026
Merged

[Nitro CLI] Refine fusion publish for migration#9617
tobias-tengler merged 3 commits intomainfrom
tte/migration-refinements

Conversation

@tobias-tengler
Copy link
Copy Markdown
Member

No description provided.

@tobias-tengler tobias-tengler marked this pull request as ready for review April 29, 2026 11:46
Copilot AI review requested due to automatic review settings April 29, 2026 11:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refines Nitro CLI Fusion publish/validate behavior for v1→v2 migration scenarios by tightening how legacy (.fgp) stage state is handled, requiring an explicit local legacy archive in certain cases, and adding support for resuming a publish via a cached request id.

Changes:

  • Update publish/validate flows to error when a stage has only a server-stored Fusion v1 archive and --legacy-v1-archive is not provided.
  • Adjust composition-base selection messaging/behavior when --legacy-v1-archive is provided and when no v2 (.far) configuration exists.
  • Add publish resume behavior (reuse cached request id and skip slot request/claim), with updated/expanded test coverage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionValidateCommandTests.cs Updates snapshots and scenarios to reflect new “local legacy archive required” behavior.
src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionPublishCommandTests.cs Expands/adjusts tests for new error path, legacy embedding behavior, and request-id resume flow.
src/Nitro/CommandLine/src/CommandLine/Messages.cs Adds a dedicated error message for missing --legacy-v1-archive when the stage has a v1 archive.
src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishHelpers.cs Implements revised precedence rules for selecting server/local archives during composition.
src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishCommand.cs Adds logic to reuse a cached publish request id (migration workflow) and skip slot request/claim.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Nitro/CommandLine/src/CommandLine/Messages.cs Outdated
Comment thread src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishHelpers.cs Outdated
Comment thread src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishCommand.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants