Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a set of analyzer/style issues across the Nitro CLI, HotChocolate, Mocha, and CookieCrumble codebases to keep builds clean under strict warning/analyzer settings.
Changes:
- Replaces some
Encoding.UTF8.GetBytes(...)usages with UTF-8 byte string literals ("..."u8.ToArray()) in tests. - Removes unused
usingdirectives and adjusts formatting to satisfy analyzers. - Aligns naming/style patterns (e.g.,
s_prefix for private static fields; simplifies some null checks/assignments).
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Nitro/CommandLine/test/CommandLine.Tests/GlobalOptionsTests.cs | Simplifies HttpClient type reference. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionMigrationHelpersTests.cs | Switches test inputs to UTF-8 byte string literals; removes unused System.Text. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishCommand.cs | Removes unused import. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionComposeCommand.cs | Removes unused imports. |
| src/Mocha/src/Mocha.EntityFrameworkCore.Postgres/Outbox/PostgresMessageOutbox.cs | Refactors transaction check pattern around outbox signaling. |
| src/HotChocolate/Fusion/test/Fusion.Packaging.Tests/FusionArchiveTests.cs | Uses UTF-8 byte string literal for test payload. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/SimpleRequiresProvides/Reviews/ReviewType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/SimpleRequiresProvides/Products/ProductType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/SimpleRequiresProvides/Accounts/UserType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/Fed2ExternalExtension/B/UserType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/Fed2ExternalExtension/A/UserType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/Fed2ExternalExtension/A/QueryType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/Fed2ExternalExtends/B/UserType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/Fed2ExternalExtends/A/UserType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/Fed2ExternalExtends/A/QueryType.cs | Doc comment reflow for analyzer compliance. |
| src/HotChocolate/Fusion/test/Fusion.Connectors.ApolloFederation.Compliance.Tests/Suites/ComplexEntityCall/Products/ProductListType.cs | Removes unused import. |
| src/HotChocolate/Fusion/src/Fusion.Composition.ApolloFederation/RemoveFederationInfrastructure.cs | Renames private static fields to s_ prefix and updates usages. |
| src/HotChocolate/Core/src/Types/Types/Descriptors/Conventions/DefaultTypeInspector.cs | Fixes comment indentation to satisfy analyzers. |
| src/HotChocolate/Core/src/Types/Types/Descriptors/Conventions/DefaultNamingConventions.cs | Removes unused import. |
| src/HotChocolate/Core/src/Types/Types/Attributes/SubscribeAttribute.cs | Removes unused import. |
| src/HotChocolate/Core/src/Types/Fetching/Extensions/ObjectFieldDataLoaderExtensions.cs | Minor formatting change for generic parameter attribute. |
| src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Middleware.cs | Minor formatting change for generic parameter attribute. |
| src/HotChocolate/Core/src/Types/Execution/Pipeline/RequestClassMiddlewareFactory.cs | Minor formatting change for generic parameter attribute. |
| src/CookieCrumble/src/CookieCrumble.HotChocolate/Formatters/StableSnapshotHelpers.cs | Simplifies null-check assignment with ??=. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9596 +/- ##
==========================================
- Coverage 74.16% 0 -74.17%
==========================================
Files 2677 0 -2677
Lines 140790 0 -140790
Branches 16371 0 -16371
==========================================
- Hits 104421 0 -104421
+ Misses 30774 0 -30774
+ Partials 5595 0 -5595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)