[Nitro CLI] Fix some Windows issues#9589
Merged
tobias-tengler merged 4 commits intomainfrom Apr 24, 2026
Merged
Conversation
tobias-tengler
changed the title
tobias-tengler
force-pushed
the
tte/nitro-cli-improvements
branch
from
0ff712f to
2256c7e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Windows terminal/rendering issues in the Nitro CLI by updating Spectre.Console and adjusting live activity rendering behavior, while also tightening API path validation.
Changes:
- Upgraded Spectre.Console packages to 0.55.2.
- Updated live activity rendering to avoid cursor-positioning artifacts (especially on Windows) by clearing the live region and re-emitting the final tree into scrollback.
- Added API path validation requiring paths to start with
/, along with a new regression test.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Apis/CreateApiCommandTests.cs | Adds coverage for rejecting API paths that don’t start with /. |
| src/Nitro/CommandLine/src/CommandLine/Services/Console/NitroConsole.cs | Implements WriteAnsi passthrough on the console wrapper. |
| src/Nitro/CommandLine/src/CommandLine/Services/Console/LiveActivitySink.cs | Changes live rendering strategy (AutoClear + re-print final tree). |
| src/Nitro/CommandLine/src/CommandLine/Services/Console/ActivityTree.cs | Adds a switch to emit/remove live-only padding used for a Spectre bug workaround. |
| src/Nitro/CommandLine/src/CommandLine/NitroRootCommand.cs | Registers a new activity-demo command at the root level. |
| src/Nitro/CommandLine/src/CommandLine/Helpers/SelectableTable.cs | Adjusts centering logic for the selectable table renderable. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Apis/CreateApiCommand.cs | Enforces leading / for --path and errors out otherwise. |
| src/Nitro/CommandLine/src/CommandLine/Commands/ActivityDemoCommand.cs | Adds a manual activity rendering demo command and scenario argument. |
| src/Directory.Packages.props | Bumps Spectre.Console / Json / Testing package versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ommand.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nsole.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9589 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.