Improve metadb approve performance#9575
Merged
michaelstaib merged 6 commits intomainfrom Apr 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes CompositeResultDocument’s metadata database (MetaDb) writes by introducing specialized append paths and a revised packed row layout to reduce per-row overhead during document construction.
Changes:
- Added specialized MetaDb append methods (
AppendNull,AppendEmptyProperty,AppendEmptyPropertyWithNullValue) and refactored genericAppendto use a sharedReserveRowhelper. - Reworked
DbRowpacking/layout and updated MetaDb fast-read accessors to match the new structure. - Expanded MetaDb tests to cover number-of-rows storage and the new specialized append behaviors, including chunk-boundary cases.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/test/Fusion.Execution.Tests/Text/Json/CompositeResultDocumentMetaDbTests.cs | Adds test coverage for new MetaDb specialized append methods and updated field storage. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultDocument.cs | Switches empty-property/value emission to the new specialized MetaDb append methods. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultDocument.MetaDb.cs | Implements specialized append fast paths, shared row reservation, and updated read/write offsets for the new row layout. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultDocument.DbRow.cs | Changes the packed row layout and exposes byte offsets for MetaDb’s direct-read paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michaelstaib
force-pushed
the
mst/optimized-metadb
branch
from
ecc8105 to
dcda442
Compare
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.