Fix composite field must have selection set rule#9555
Merged
michaelstaib merged 2 commits intomainfrom Apr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes validation of the GraphQL “leaf field selections” rule so composite fields wrapped in list/non-null types correctly require a selection set (notably affecting introspection fields like types { ofType } and fields { type }), and adds regression coverage in Fusion ASP.NET Core tests.
Changes:
- Unwrap parent types in
LeafFieldSelectionsRulebefore looking up fields, ensuring wrapped composite parent types are validated correctly. - Add two new Fusion gateway introspection regression tests plus their snapshot baselines for missing selection sets.
- Default Fusion test gateway hosting environment to Development to avoid environment-driven security behavior interfering with tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Core/src/Validation/Rules/LeafFieldSelectionsRule.cs | Unwraps parentType via NamedType() before validating field selections. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/IntrospectionTests.cs | Adds regression tests for introspection composite fields without selection sets. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/FusionTestBase.cs | Injects a default IHostEnvironment (Development) for gateway test servers. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/snapshots/IntrospectionTests.Introspection_OfType_Without_SelectionSet.yaml | Snapshot baseline for ofType missing selection set error. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/snapshots/IntrospectionTests.Introspection_Field_Type_Without_SelectionSet.yaml | Snapshot baseline for type missing selection set error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.