Skip to content

[Fusion] Include internal types/fields during source schema validation #9554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glen-84 merged 2 commits into from
Apr 15, 2026
Merged

[Fusion] Include internal types/fields during source schema validation #9554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8019ce5
[Fusion] Include internal types/fields during source schema validation
glen-84 Apr 15, 2026
6836530
Update gateway.far
glen-84 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified src/HotChocolate/Fusion/benchmarks/k6/eShop.Gateway/gateway.far
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/HotChocolate/Fusion/benchmarks/k6/eShop.Reviews/ProductQueries.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ namespace eShop.Reviews;
public static partial class ProductQueries
{
[Lookup, Internal]
public static Product GetProduct([ID] string upc)
public static Product? GetProduct([ID] string upc)
=> new() { Upc = upc };
}
4 changes: 2 additions & 2 deletions src/HotChocolate/Fusion/benchmarks/k6/eShop.Reviews/schema.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ type Product {
}

type Query {
product(upc: ID!): Product! @lookup @internal
product(upc: ID!): Product @lookup @internal
review(id: ID!): Review @lookup
user(id: ID!): User @lookup @internal
}
Expand Down Expand Up @@ -43,7 +43,7 @@ type User @internal {
id: ID!
name: String!
}

directive @internal on OBJECT | FIELD_DEFINITION
"""
directive @internal on OBJECT | FIELD_DEFINITION
Expand Down
11 changes: 0 additions & 11 deletions src/HotChocolate/Fusion/src/Fusion.Composition/SourceSchemaValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
using HotChocolate.Fusion.Errors;
using HotChocolate.Fusion.Events;
using HotChocolate.Fusion.Events.Contracts;
using HotChocolate.Fusion.Extensions;
using HotChocolate.Fusion.Logging.Contracts;
using HotChocolate.Fusion.Results;
using HotChocolate.Types.Mutable;
Expand Down Expand Up @@ -33,11 +32,6 @@ private void PublishEvents()

foreach (var type in schema.Types)
{
if (type is MutableObjectTypeDefinition { IsInternal: true })
{
continue;
}

PublishEvent(new TypeEvent(type, schema), context);

if (type is MutableComplexTypeDefinition complexType)
Expand All @@ -46,11 +40,6 @@ private void PublishEvents()

foreach (var field in complexType.Fields)
{
if (field.IsInternal)
{
continue;
}

PublishEvent(new OutputFieldEvent(field, type, schema), context);

foreach (var argument in field.Arguments)
Expand Down
Loading