Fix assignment of JSON Schema formats in the OpenAPI adapter#9551
Merged
Fix assignment of JSON Schema formats in the OpenAPI adapter#9551
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes JSON Schema/OpenAPI format generation for scalar types in the OpenAPI adapter so emitted OpenAPI documents reflect correct numeric widths/precision (and adds coverage for unsigned scalar formats).
Changes:
- Update scalar-to-OpenAPI
formatmapping to correctly emitdoubleforFloat, and correct integer widths forByte/Short/Longplus unsigned integer scalar formats. - Extend the OpenAPI adapter integration test schema and HTTP POST test payload to include unsigned numeric scalar fields.
- Update OpenAPI snapshot baselines to reflect the corrected formats.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Adapters/src/Adapters.OpenApi.AspNetCore/DynamicOpenApiDocumentTransformer.cs | Adjusts GetJsonSchemaFormat to correctly assign formats for spec scalars and ChiliCream scalar URIs (including unsigned scalars). |
| src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/TestSchema.cs | Adds unsigned scalar fields to the complex object input/output used by OpenAPI integration tests. |
| src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/Endpoints/HttpEndpointIntegrationTestBase.cs | Extends complex-object POST request JSON to include unsigned scalar fields. |
| src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/OpenApi/snapshots/OpenApiIntegrationTestBase.OpenApi_Includes_Initial_Routes_NET9_0.json | Snapshot update for corrected scalar formats and added unsigned fields. |
| src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/OpenApi/snapshots/OpenApiIntegrationTestBase.OpenApi_Includes_Initial_Routes_NET9_0_Fusion.json | Snapshot update for corrected scalar formats and added unsigned fields (Fusion). |
| src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/OpenApi/snapshots/OpenApiIntegrationTestBase.OpenApi_Includes_Initial_Routes_NET10_0.json | Snapshot update for corrected scalar formats and added unsigned fields. |
| src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/OpenApi/snapshots/OpenApiIntegrationTestBase.OpenApi_Includes_Initial_Routes_NET10_0_Fusion.json | Snapshot update for corrected scalar formats and added unsigned fields (Fusion). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)