Skip to content

Fix restore#9542

Merged
glen-84 merged 1 commit intomainfrom
gai/fix-restore
Apr 13, 2026
Merged

Fix restore#9542
glen-84 merged 1 commit intomainfrom
gai/fix-restore

Conversation

@glen-84
Copy link
Copy Markdown
Member

@glen-84 glen-84 commented Apr 13, 2026

Summary of the changes (Less than 80 chars)

  • Fix restore.

Copilot AI review requested due to automatic review settings April 13, 2026 13:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Mocha demo catalog test project’s target framework configuration to resolve restore/build issues caused by inherited multi-targeting settings.

Changes:

  • Switch the test project from TargetFramework to TargetFrameworks and pin it to net10.0 to explicitly override inherited TargetFrameworks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFrameworks>net10.0</TargetFrameworks>
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project now uses TargetFrameworks with a single TFM. In a few places in this repo, single-target projects that use TargetFrameworks also set TargetFramework to the same value (e.g. src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/Fusion.Execution.Benchmarks.csproj:5-6, src/Mocha/benchmarks/Directory.Build.props:4-5). Consider adding TargetFramework here as well to align with that pattern (or alternatively switch back to TargetFramework and explicitly clear/override any inherited TargetFrameworks).

Suggested change
<TargetFrameworks>net10.0</TargetFrameworks>
<TargetFrameworks>net10.0</TargetFrameworks>
<TargetFramework>net10.0</TargetFramework>

Copilot uses AI. Check for mistakes.
@glen-84 glen-84 merged commit dfc941e into main Apr 13, 2026
262 of 264 checks passed
@glen-84 glen-84 deleted the gai/fix-restore branch April 13, 2026 14:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (666707b) to head (e53fdfb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #9542   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants