Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the Mocha demo catalog test project’s target framework configuration to resolve restore/build issues caused by inherited multi-targeting settings.
Changes:
- Switch the test project from
TargetFrameworktoTargetFrameworksand pin it tonet10.0to explicitly override inheritedTargetFrameworks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <TargetFrameworks>net10.0</TargetFrameworks> |
There was a problem hiding this comment.
This project now uses TargetFrameworks with a single TFM. In a few places in this repo, single-target projects that use TargetFrameworks also set TargetFramework to the same value (e.g. src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/Fusion.Execution.Benchmarks.csproj:5-6, src/Mocha/benchmarks/Directory.Build.props:4-5). Consider adding TargetFramework here as well to align with that pattern (or alternatively switch back to TargetFramework and explicitly clear/override any inherited TargetFrameworks).
| <TargetFrameworks>net10.0</TargetFrameworks> | |
| <TargetFrameworks>net10.0</TargetFrameworks> | |
| <TargetFramework>net10.0</TargetFramework> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9542 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of the changes (Less than 80 chars)