Remove redundant 'string.Format()' calls#9529
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes redundant string.Format(...) usages in HotChocolate error construction by leveraging existing ErrorBuilder.SetMessage(format, args) overloads, and enforces this pattern via a ReSharper inspection severity.
Changes:
- Replace
SetMessage(string.Format(...))withSetMessage(format, args)in core throwing helpers. - Replace
SetMessage(string.Format(...))withSetMessage(format, args)in ASP.NET Core pipeline error helper. - Configure ReSharper to treat redundant
string.Formatcalls as errors via.editorconfig.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/HotChocolate/Core/src/Types/Utilities/ThrowHelper.cs | Uses ErrorBuilder.SetMessage(format, arg) instead of pre-formatting the message. |
| src/HotChocolate/Core/src/Types/Execution/ThrowHelper.cs | Same simplification for the OneOfFieldMustBeNonNull error. |
| src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Utilities/ErrorHelper.cs | Same simplification for the BatchSizeExceeded error. |
| .editorconfig | Elevates ReSharper “redundant string.Format call” highlighting to error to prevent regressions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9529 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)