Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GraphQL specification reference URLs/anchors used in error metadata and snapshots to match the current spec section IDs.
Changes:
- Updated various test snapshots to use corrected
specifiedByanchors (e.g., field selections, directive locations, directive type validation). - Updated schema type-system
DirectiveValidationspec anchor constant to the corrected section ID. - Removed obsolete snapshot files for mutation-root defer cases that no longer have corresponding tests.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Core/test/Validation.Tests/snapshots/FieldSelectionMergingRuleTests.DoesNotInfiniteLoopOnTransitivelyRecursiveFragment.snap | Updates specifiedBy anchor to #sec-Field-Selections. |
| src/HotChocolate/Core/test/Validation.Tests/snapshots/FieldSelectionMergingRuleTests.DoesNotInfiniteLoopOnRecursiveFragment.snap | Updates specifiedBy anchor to #sec-Field-Selections. |
| src/HotChocolate/Core/test/Validation.Tests/snapshots/FieldSelectionMergingRuleTests.DoesNotInfiniteLoopOnImmediatelyRecursiveFragment.snap | Updates specifiedBy anchor to #sec-Field-Selections. |
| src/HotChocolate/Core/test/Validation.Tests/snapshots/DirectivesAreDefinedRuleTests.WithMisplacedDirectives.snap | Fixes directive-location spec anchor casing (Are-in-Valid-Locations). |
| src/HotChocolate/Core/test/Validation.Tests/snapshots/DeferAndStreamDirectivesAreUsedOnValidRootFieldTests.Defer_On_Mutation_Root.snap | Removes obsolete snapshot (no longer referenced by tests). |
| src/HotChocolate/Core/test/Validation.Tests/snapshots/DeferAndStreamDirectivesAreUsedOnValidRootFieldTests.Defer_On_Mutation_Root_In_Nested_Fragment.snap | Removes obsolete snapshot (no longer referenced by tests). |
| src/HotChocolate/Core/test/Types.Tests/Types/Validation/snapshots/DirectiveValidationRuleTests.RejectRequiredArgumentThatIsDeprecated.snap | Updates directive type-validation spec anchor. |
| src/HotChocolate/Core/test/Types.Tests/Types/Validation/snapshots/DirectiveValidationRuleTests.RejectDirectiveWithInvalidName.snap | Updates directive type-validation spec anchor. |
| src/HotChocolate/Core/test/Types.Tests/Types/Validation/snapshots/DirectiveValidationRuleTests.RejectArgumentsWithInvalidName.snap | Updates directive type-validation spec anchor. |
| src/HotChocolate/Core/test/Types.Tests/Types/snapshots/DirectiveTypeTests.SchemaFirst_DeprecatedDirective_NonNullableField_Invalid.snap | Updates directive type-validation spec anchor. |
| src/HotChocolate/Core/test/Types.Tests/Types/snapshots/DirectiveTypeTests.CodeFirst_DeprecatedInputTypes_NonNullableField_Invalid.snap | Updates directive type-validation spec anchor. |
| src/HotChocolate/Core/test/Types.Tests/Types/snapshots/DirectiveTypeTests.AnnotationBased_DeprecatedInputTypes_NonNullableField_Invalid.snap | Updates directive type-validation spec anchor. |
| src/HotChocolate/Core/src/Types/Utilities/ErrorHelper.cs | Updates directive type-validation section ID used to build specifiedBy URLs. |
| src/HotChocolate/Core/src/Types/Configuration/Validation/DirectiveValidationRule.cs | Updates the spec URL in the file header comment to the corrected anchor/version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 1, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)