Fix "Expression is always true" errors

src/HotChocolate/Core/src/Types/Execution/Pipeline/OperationExecutionMiddleware.cs

@@ -264,6 +264,7 @@ private async Task<IExecutionResult> ExecuteQueryOrMutationAsync(
     {
         var queryType = context.Schema.QueryType;
 
+        // ReSharper disable once ConditionIsAlwaysTrueOrFalseAccordingToNullableAPIContract
         if (queryType is null)
         {
             return null;

src/HotChocolate/Core/test/Types.CursorPagination.Tests/UseConnectionAttributeTests.cs

@@ -71,7 +71,7 @@ public async Task UseConnectionAttribute_Clamps_Default_Page_Size_To_Max_Page_Si
         var operationResult = result.ExpectOperationResult();
 
         Assert.True(
-            operationResult.Errors is null || operationResult.Errors.Count == 0,
+            operationResult.Errors.Count == 0,
             $"Expected no errors but got: {operationResult.ToJson()}");
 
         using var document = JsonDocument.Parse(operationResult.ToJson());

src/HotChocolate/Core/test/Types.Tests/Types/ObjectTypeTests.cs

@@ -2413,6 +2413,7 @@ public static class ResolveWithStaticQueryResolver
 
         public static Task<string> FooAsync() => Task.FromResult("Foo");
 
+        // ReSharper disable once ConditionIsAlwaysTrueOrFalseAccordingToNullableAPIContract
         public static Task<bool> BarAsync(IResolverContext context)
             => Task.FromResult(context is not null);
     }

src/HotChocolate/Core/test/Types.Tests/Types/Relay/NodeResolverTests.cs

@@ -275,7 +275,7 @@ ... on Entity {
         var operationResult = result.ExpectOperationResult();
 
         Assert.True(
-            operationResult.Errors is null || operationResult.Errors.Count == 0,
+            operationResult.Errors.Count == 0,
             $"Expected no errors but got: {operationResult.ToJson()}");
 
         using var document = JsonDocument.Parse(operationResult.ToJson());

src/HotChocolate/Core/test/Types.Tests/Types/Relay/NodeTypeTests.cs

@@ -149,7 +149,7 @@ ... on Foo {
         var operationResult = result.ExpectOperationResult();
 
         Assert.True(
-            operationResult.Errors is null || operationResult.Errors.Count == 0,
+            operationResult.Errors.Count == 0,
             $"Expected no errors but got: {operationResult.ToJson()}");
 
         using var document = JsonDocument.Parse(operationResult.ToJson());

src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionScalarHandler.cs

@@ -128,6 +128,7 @@ private static bool TryGetTopLevelProperty(
         {
             var current = expression;
 
+            // ReSharper disable once ConditionIsAlwaysTrueOrFalseAccordingToNullableAPIContract
             while (current is not null)
             {
                 current = UnwrapConvert(current);

src/HotChocolate/Fusion/src/Fusion.Execution/Transport/Http/FileEntryBuilder.cs

@@ -138,13 +138,13 @@ private static Path ParsePrefix(string pathPrefix)
     /// </summary>
     private static Path PopAfterValue(Path path)
     {
-        if (path.Parent is not null && path is IndexerPathSegment indexer)
+        if (path is IndexerPathSegment indexer)
         {
             // Inside an array — advance to next index.
             return path.Parent.Append(indexer.Index + 1);
         }
 
-        if (path.Parent is not null && path is NamePathSegment)
+        if (path is NamePathSegment)
         {
             // Inside an object — pop the property name.
             return path.Parent;

src/HotChocolate/Utilities/src/Utilities.Buffers/ChunkedArrayWriter.cs

@@ -623,6 +623,7 @@ public void Reset()
         // Return any pre-allocated chunks beyond the used range.
         for (var i = usedChunks; i < _chunkCount; i++)
         {
+            // ReSharper disable once ConditionIsAlwaysTrueOrFalseAccordingToNullableAPIContract
             if (_chunks[i] is not null)
             {
                 JsonMemory.Return(_memoryKind, _chunks[i]);

src/Mocha/src/Mocha/Runtime/MessagingRuntimeHostedService.cs

@@ -16,9 +16,6 @@ public async Task StartAsync(CancellationToken cancellationToken)
 
     public async Task StopAsync(CancellationToken cancellationToken)
     {
-        if (_runtime is not null)
-        {
-            await _runtime.DisposeAsync();
-        }
+        await _runtime.DisposeAsync();
     }
 }