Skip to content

Remove implicit save changes in mocha ef core middleware #9501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PascalSenn merged 2 commits into from
Apr 2, 2026
Merged

Remove implicit save changes in mocha ef core middleware #9501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
093d307
Remove implicit save changes in mocha ef core middleware
PascalSenn Apr 2, 2026
1501163
Apply suggestion from @PascalSenn
PascalSenn Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Mocha/src/Mocha.EntityFrameworkCore/EntityFrameworkTransactionMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ namespace Mocha.EntityFrameworkCore;

/// <summary>
/// Mediator middleware that wraps command handling in a database transaction.
/// Commits on success and rolls back on failure.
/// Commits on success and rolls back on failure. Handlers are responsible for
/// calling <see cref="DbContext.SaveChangesAsync(CancellationToken)"/> themselves.
/// Queries and notifications are excluded by default but can be opted in via
/// <see cref="MediatorEntityFrameworkOptions.ShouldCreateTransaction"/>.
/// </summary>
Expand Down Expand Up @@ -37,7 +38,6 @@ await strategy.ExecuteAsync(async ct =>
{
await next(context);

await dbContext.SaveChangesAsync(ct);
await transaction.CommitAsync(ct);
}
catch
Expand All @@ -57,7 +57,6 @@ await strategy.ExecuteAsync(async ct =>
{
await next(context);

await dbContext.SaveChangesAsync(context.CancellationToken);
await transaction.CommitAsync(context.CancellationToken);
}
catch
Expand Down
8 changes: 3 additions & 5 deletions website/src/docs/mocha/v1/mediator/pipeline-and-middleware.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ public static class TransactionMiddleware
try
{
await next(ctx);
await db.SaveChangesAsync(ctx.CancellationToken);
await tx.CommitAsync(ctx.CancellationToken);
}
catch
Expand Down Expand Up @@ -462,11 +461,10 @@ The middleware (key: `"EntityFrameworkTransaction"`):
1. Checks at compile time whether the pipeline is for a command. Queries and notifications are excluded by default - the middleware is not present in their pipelines at all.
2. Begins a database transaction
3. Calls the next middleware or handler
4. Calls `SaveChangesAsync` on success
5. Commits the transaction
6. Rolls back on any exception
4. Commits the transaction on success
5. Rolls back on any exception

Your command handlers do not need to call `SaveChangesAsync` or manage transactions - the middleware handles both.
Your command handlers are responsible for calling `SaveChangesAsync` to persist their changes. The middleware handles the transaction lifecycle - your handlers do not need to call `BeginTransactionAsync`, `CommitAsync`, or `RollbackAsync`.

## Customizing transaction scope

Expand Down
Loading