Skip to content

Improve object and array parsing on SourceResultDocument #9460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 2 commits into from
Mar 27, 2026
Merged

Improve object and array parsing on SourceResultDocument #9460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5c7d0e
Improve object and array parsing on SourceResultDocument
michaelstaib Mar 27, 2026
3edf49d
Merge branch 'main' into mst/SourceResultDocParse
michaelstaib Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 38 additions & 92 deletions src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/SourceResultDocument.Parse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ internal static SourceResultDocument ParseMultipleSegments(
private static void ParseJson(ref Utf8JsonReader reader, ref MetaDb metaDb, bool skipInitialRead = false)
{
Span<Cursor> containerStart = stackalloc Cursor[64];
Span<int> containerChildCount = stackalloc int[64];
var containerIsArrayBits = 0UL;
var stackIndex = 0;

while (skipInitialRead || reader.Read())
Expand All @@ -173,40 +175,50 @@ private static void ParseJson(ref Utf8JsonReader reader, ref MetaDb metaDb, bool
tokenLength--;
}

// Count direct children incrementally.
if (stackIndex > 0)
{
if (tokenType == JsonTokenType.PropertyName)
{
containerChildCount[stackIndex - 1]++;
}
else if ((containerIsArrayBits & (1UL << (stackIndex - 1))) != 0
&& tokenType is not (JsonTokenType.EndObject or JsonTokenType.EndArray))
{
containerChildCount[stackIndex - 1]++;
}
}

switch (tokenType)
{
case JsonTokenType.StartObject:
{
var startCursor = metaDb.Append(tokenType, location);
containerStart[stackIndex++] = startCursor;
containerStart[stackIndex] = metaDb.Append(tokenType, location);
containerChildCount[stackIndex] = 0;
containerIsArrayBits &= ~(1UL << stackIndex);
stackIndex++;
break;
}

case JsonTokenType.EndObject:
{
var startCursor = containerStart[--stackIndex];
CloseObject(ref metaDb, startCursor, location);
--stackIndex;
CloseObject(ref metaDb, containerStart[stackIndex], location, containerChildCount[stackIndex]);

if (stackIndex == 0)
{
return;
}
break;
}

case JsonTokenType.StartArray:
{
var startCursor = metaDb.Append(tokenType, location);
containerStart[stackIndex++] = startCursor;
containerStart[stackIndex] = metaDb.Append(tokenType, location);
containerChildCount[stackIndex] = 0;
containerIsArrayBits |= 1UL << stackIndex;
stackIndex++;
break;
}

case JsonTokenType.EndArray:
{
var startCursor = containerStart[--stackIndex];
CloseArray(ref metaDb, startCursor, location);
--stackIndex;
CloseArray(ref metaDb, containerStart[stackIndex], location, containerChildCount[stackIndex]);
break;
}

case JsonTokenType.PropertyName:
case JsonTokenType.String:
Expand Down Expand Up @@ -241,17 +253,12 @@ private static void ParseJson(ref Utf8JsonReader reader, ref MetaDb metaDb, bool
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static void CloseObject(ref MetaDb metaDb, Cursor startId, int location)
private static void CloseObject(ref MetaDb metaDb, Cursor startId, int location, int properties)
{
var startRow = metaDb.Get(startId);

if (startRow.TokenType != JsonTokenType.StartObject)
{
throw new JsonException($"Expected {JsonTokenType.StartObject} but found {startRow.TokenType}.");
}
Debug.Assert(metaDb.Get(startId).TokenType == JsonTokenType.StartObject);

var endId = metaDb.Append(JsonTokenType.EndObject, location);
var (properties, rows) = CalculateObjectPropertyCount(ref metaDb, startId, endId);
var rows = CursorDistance(startId, endId);

metaDb.SetLength(startId, properties);
metaDb.SetNumberOfRows(startId, rows);
Expand All @@ -260,24 +267,23 @@ private static void CloseObject(ref MetaDb metaDb, Cursor startId, int location)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static void CloseArray(ref MetaDb metaDb, Cursor startCursor, int location)
private static void CloseArray(ref MetaDb metaDb, Cursor startCursor, int location, int elements)
{
var startRow = metaDb.Get(startCursor);

if (startRow.TokenType != JsonTokenType.StartArray)
{
throw new JsonException($"Expected {JsonTokenType.StartArray} but found {startRow.TokenType}.");
}
Debug.Assert(metaDb.Get(startCursor).TokenType == JsonTokenType.StartArray);

var endId = metaDb.Append(JsonTokenType.EndArray, location);
var (elements, rows) = CalculateArrayCounts(ref metaDb, startCursor, endId);
var rows = CursorDistance(startCursor, endId);

metaDb.SetLength(startCursor, elements);
metaDb.SetNumberOfRows(startCursor, rows);
metaDb.SetLength(endId, elements);
metaDb.SetNumberOfRows(endId, rows);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static int CursorDistance(Cursor start, Cursor end)
=> ((end.Chunk - start.Chunk) * Cursor.RowsPerChunk) + end.Row - start.Row + 1;

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static void AppendStringToken(
ref MetaDb metaDb,
Expand Down Expand Up @@ -305,66 +311,6 @@ private static void AppendNumberToken(
tokenLength,
ContainsScientificNotation(reader.ValueSpan));

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static (int Properties, int Rows) CalculateObjectPropertyCount(
ref MetaDb metaDb,
Cursor startId,
Cursor endId)
{
if (startId + 1 == endId)
{
return (0, 2);
}

var properties = 0;
var rows = 2;
var current = startId + 1;

while (current < endId)
{
// Property name (string)
properties++;
var row = metaDb.Get(current);
Debug.Assert(row.TokenType is JsonTokenType.PropertyName);

current += row.NumberOfRows;
rows += row.NumberOfRows;

// Property value (any)
row = metaDb.Get(current);
current += row.NumberOfRows;
rows += row.NumberOfRows;
}

return (properties, rows);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static (int Elements, int Rows) CalculateArrayCounts(
ref MetaDb metaDb,
Cursor startId,
Cursor endId)
{
if (startId + 1 == endId)
{
return (0, 2);
}

var elements = 0;
var rows = 2;
var current = startId + 1;

while (current < endId)
{
elements++;
var row = metaDb.Get(current);
rows += row.NumberOfRows;
current += row.NumberOfRows;
}

return (elements, rows);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static bool ContainsEscapeSequences(Utf8JsonReader reader)
{
Expand Down
Loading