Skip to content

Add fast path for scalars in the value completion #9445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 1 commit into from
Mar 24, 2026
Merged

Add fast path for scalars in the value completion #9445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,24 @@ public bool BuildResult(
continue;
}

var propertyValue = property.Value;

// Fast path: when there are no errors and the source value is a
// scalar (string, number, bool) we can set it directly without
// going through the full TryCompleteValue type-dispatch chain.
if (errorTrie is null && propertyValue.IsScalarValue())
{
resultField.SetLeafValue(propertyValue);
continue;
}

var selection = resultField.AssertSelection();
ErrorTrie? errorTrieForResponseName = null;
errorTrie?.TryGetValue(selection.ResponseName, out errorTrieForResponseName);

var childSet = resultSelectionSet.TryGetChild(selection.ResponseName);
if (!TryCompleteValue(
property.Value,
propertyValue,
resultField,
errorTrieForResponseName,
selection,
Expand Down Expand Up @@ -652,14 +663,31 @@ private bool TryCompleteObjectValue(
continue;
}

var propertyValue = property.Value;

// Fast path: when there are no errors and the source value is a
// scalar (string, number, bool) we can set it directly without
// going through the full TryCompleteValue type-dispatch chain.
if (errorTrie is null && propertyValue.IsScalarValue())
{
targetProperty.SetLeafValue(propertyValue);
continue;
}

var selection = targetProperty.AssertSelection();

ErrorTrie? errorTrieForResponseName = null;
errorTrie?.TryGetValue(selection.ResponseName, out errorTrieForResponseName);

var childSet = resultSelectionSet?.TryGetChild(selection.ResponseName, objectType);
if (!TryCompleteValue(property.Value,
targetProperty, errorTrieForResponseName, selection, selection.Type, depth, childSet))
if (!TryCompleteValue(
propertyValue,
targetProperty,
errorTrieForResponseName,
selection,
selection.Type,
depth,
childSet))
{
return false;
}
Expand Down Expand Up @@ -709,4 +737,13 @@ file static class ValueCompletionExtensions
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool IsNullOrUndefined(this SourceResultElement element)
=> element.ValueKind is JsonValueKind.Null or JsonValueKind.Undefined;

/// <summary>
/// Returns <c>true</c> if the element is a scalar JSON value (string, number, true, or false)
/// that can be set directly without type dispatch or error trie lookup.
/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool IsScalarValue(this SourceResultElement element)
=> element.ValueKind is JsonValueKind.String or JsonValueKind.Number
or JsonValueKind.True or JsonValueKind.False;
}
Loading