Skip to content

[Diagnostics] Do not mark GraphQL request span as server span#9444

Merged
tobias-tengler merged 1 commit intomainfrom
tte/do-not-mark-graphql-span-as-server
Mar 25, 2026
Merged

[Diagnostics] Do not mark GraphQL request span as server span#9444
tobias-tengler merged 1 commit intomainfrom
tte/do-not-mark-graphql-span-as-server

Conversation

@tobias-tengler
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 24, 2026 21:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates HotChocolate diagnostics span creation so the “GraphQL Operation” activity is no longer created as a server span, aligning it with the expectation that the incoming transport (e.g., ASP.NET) owns the server span and GraphQL execution should be an internal child activity.

Changes:

  • Stop explicitly setting ActivityKind.Server when starting the “GraphQL Operation” activity (defaults to ActivityKind.Internal).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tobias-tengler tobias-tengler merged commit 3a7deb3 into main Mar 25, 2026
131 checks passed
@tobias-tengler tobias-tengler deleted the tte/do-not-mark-graphql-span-as-server branch March 25, 2026 06:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (67b637e) to head (e18bc8d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #9444   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants