Skip to content

Introduce BeginExecute to express fire-and-forget intent on ExecutionNode #9432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 1 commit into from
Mar 23, 2026
Merged

Introduce BeginExecute to express fire-and-forget intent on ExecutionNode #9432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HotChocolate/Fusion/src/Fusion.Execution/Execution/ExecutionState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public void StartNode(OperationPlanContext context, ExecutionNode node, Cancella
}

RemoveFromBacklog(node.Id, NodeStateNone);
_ = node.ExecuteAsync(context, cancellationToken);
node.BeginExecute(context, cancellationToken);
}

public void EnqueueForCompletion(ExecutionNodeResult result)
Expand Down
9 changes: 8 additions & 1 deletion src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/ExecutionNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,14 @@ public abstract class ExecutionNode : IOperationPlanNode, IEquatable<ExecutionNo
/// </summary>
public ReadOnlySpan<IOperationPlanNode> OptionalDependencies => _optionalDependencies;

public async Task ExecuteAsync(
#pragma warning disable CA2012
public void BeginExecute(
OperationPlanContext context,
CancellationToken cancellationToken = default)
=> _ = ExecuteAsync(context, cancellationToken);
#pragma warning restore CA2012

private async ValueTask ExecuteAsync(
OperationPlanContext context,
CancellationToken cancellationToken = default)
{
Expand Down
Loading