[GreenDonut] Re-add Page<T>.Items

[tobias-tengler]

No description provided.

[Copilot]

Pull request overview

Reintroduces an Items collection on Page<T> in GreenDonut and wires it through page implementations and EF paging helpers to avoid re-materializing items from entries. Also updates the v16 migration guide headings and removes a migration note about ToBatchPageAsync’s valueSelector.

Changes:

• Add Page<T>.Items with optional constructor-provided backing store and fallback derivation from Entries.
• Thread the optional items parameter through ValueCursorPage, ElementCursorPage, and EF ToPageAsync/CreateValueCursorPage.
• Documentation formatting updates in the HotChocolate v16 migration guide (including removal of a ToBatchPageAsync note).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
website/src/docs/hotchocolate/v16/migrating/migrate-from-15-to-16.md	Adjusts migration guide headings/sections; removes a ToBatchPageAsync migration note.
src/GreenDonut/src/GreenDonut.Data.Primitives/Page.cs	Re-adds Items to Page<T> with lazy derivation and new ctor parameter.
src/GreenDonut/src/GreenDonut.Data.Primitives/ValueCursorPage.cs	Pass-through support for optional precomputed items.
src/GreenDonut/src/GreenDonut.Data.Primitives/ElementCursorPage.cs	Pass-through support for optional precomputed items.
src/GreenDonut/src/GreenDonut.Data.EntityFramework/Extensions/PagingQueryableExtensions.cs	Captures immutable items once and passes through to avoid re-derivation when Items is accessed.

Comments suppressed due to low confidence (1)

src/GreenDonut/src/GreenDonut.Data.Primitives/Page.cs:111

• Page<T>.Items has been reintroduced, but there are existing PageTests covering cursor behavior and empty pages without any assertions around the new Items property. Adding a couple of tests that Items matches the original input (for Page.Create(...)) and is correctly derived from Entries would help prevent regressions.

    public ImmutableArray<T> Items => _items ??= CreateItemsFromEntries(Entries);

    /// <summary>
    /// Gets the number of items in this page.
    /// </summary>
    public int Count => Entries.Length;

    /// <summary>
    /// Gets the item at the specified index.
    /// </summary>
    /// <param name="index">
    /// The zero-based index of the item.
    /// </param>
    public T this[int index] => Entries[index].Item;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (299c245) to head (0c117b9).

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #9420   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.