Skip to content

[Nitro CLI] Add stage delete command#9417

Merged
PascalSenn merged 8 commits intomainfrom
pse/add-nitr-stage-delete
Mar 24, 2026
Merged

[Nitro CLI] Add stage delete command#9417
PascalSenn merged 8 commits intomainfrom
pse/add-nitr-stage-delete

Conversation

@PascalSenn
Copy link
Copy Markdown
Member

@PascalSenn PascalSenn commented Mar 22, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 22, 2026 22:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new nitro stage delete command backed by a new forceDeleteStageById GraphQL mutation, and updates the CLI GraphQL schema/operation documents accordingly.

Changes:

  • Add a new stage delete subcommand (DeleteStageCommand) that calls forceDeleteStageById.
  • Add the GraphQL mutation document used by the command.
  • Update schema.graphql to include forceDeleteStageById (and a large set of additional schema directive/annotation updates).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

File Description
src/Nitro/CommandLine/src/CommandLine/schema.graphql Adds forceDeleteStageById input/payload/error union and updates many fields with directives (@cost, @listSize, @authorize).
src/Nitro/CommandLine/src/CommandLine/Commands/Stages/StageCommand.cs Registers the new delete subcommand under stage.
src/Nitro/CommandLine/src/CommandLine/Commands/Stages/DeleteStageCommand.graphql Defines the mutation operation used by the CLI to force-delete a stage and return the updated stages list.
src/Nitro/CommandLine/src/CommandLine/Commands/Stages/DeleteStageCommand.cs Implements the nitro stage delete command, including confirmation and result formatting.
Comments suppressed due to low confidence (1)

src/Nitro/CommandLine/src/CommandLine/schema.graphql:3483

  • The deprecation reason string has a grammar issue: "Not longer in use" should be "No longer in use".
  throughput(from: DateTime! operationKinds: [OperationKind!] @deprecated(reason: "Not longer in use") to: DateTime!): OperationThroughputGraph

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Nitro/CommandLine/src/CommandLine/schema.graphql Outdated
Comment thread src/Nitro/CommandLine/src/CommandLine/schema.graphql Outdated
Copy link
Copy Markdown
Member

@tobias-tengler tobias-tengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to re-generate the persisted operations the command for it is in the README.md in the CLI project

Comment thread src/Nitro/CommandLine/src/CommandLine/Commands/Stages/DeleteStageCommand.cs Outdated
Comment thread src/Nitro/CommandLine/src/CommandLine/Commands/Stages/DeleteStageCommand.cs Outdated
@tobias-tengler tobias-tengler changed the title Adds stage delete to nitro cli [Nitro CLI] Add stage delete command Mar 24, 2026
@PascalSenn PascalSenn merged commit 6c2c814 into main Mar 24, 2026
127 checks passed
@PascalSenn PascalSenn deleted the pse/add-nitr-stage-delete branch March 24, 2026 15:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (ff9cb02) to head (f0632ee).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #9417   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants