Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Modified storage event type from MCP storage change notifications, simplifying the change model to “Added (upsert)” and “Removed” across prompts and tools.
Changes:
- Removed
ModifiedfromPromptStorageEventTypeandOperationToolStorageEventType. - Updated
McpStorageObserverto handle onlyAddedandRemoved. - Updated the MCP test storage implementation to emit
Addedfor upserts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/HotChocolate/Adapters/test/Adapters.Mcp.Tests/TestMcpStorage.cs | Adjusts test storage event emission and null-check logic for the new event type set. |
| src/HotChocolate/Adapters/src/Adapters.Mcp.Core/Storage/PromptStorageEventType.cs | Removes Modified from prompt storage event enum. |
| src/HotChocolate/Adapters/src/Adapters.Mcp.Core/Storage/OperationToolStorageEventType.cs | Removes Modified from tool storage event enum. |
| src/HotChocolate/Adapters/src/Adapters.Mcp.Core/McpStorageObserver.cs | Drops Modified handling in batch processing for prompts/tools. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Modifiedevent type.