Add overload for AddMcpStorage taking a factory and skipIf#9367
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new AddMcpStorage overload accepting a factory delegate and optional skipIf predicate, and refactors warmup task registration into a shared helper method.
Changes:
- New
AddMcpStorage<T>(factory, skipIf)overload in bothFusionGatewayBuilderExtensionsandRequestExecutorBuilderExtensions - Warmup task logic extracted into private
AddMcpStorageWarmupTaskhelper, now accepting an optionalskipIfparameter - Added
AspNetCoreproject reference toAdapters.Mcpproject
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| FusionGatewayBuilderExtensions.cs | New factory+skipIf overload, extracted warmup task helper |
| RequestExecutorBuilderExtensions.cs | Same new overload and warmup task extraction |
| HotChocolate.Adapters.Mcp.csproj | Added AspNetCore project reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)