Skip to content

Mark migration files as generated code#9346

Merged
glen-84 merged 1 commit intomainfrom
gai/mark-migrations-generated
Mar 10, 2026
Merged

Mark migration files as generated code#9346
glen-84 merged 1 commit intomainfrom
gai/mark-migrations-generated

Conversation

@glen-84
Copy link
Copy Markdown
Member

@glen-84 glen-84 commented Mar 10, 2026

Summary of the changes (Less than 80 chars)

  • Mark migration files as generated code.

Copilot AI review requested due to automatic review settings March 10, 2026 08:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces a global .editorconfig rule that suppressed all analyzer diagnostics for files under **/Migrations/**.cs with per-directory .editorconfig files in three Demo project migration directories. The new approach uses generated_code = true to mark migration files as generated code, which is the recommended Roslyn/Microsoft approach for suppressing analyzers on auto-generated files.

Changes:

  • Removed the global [**/Migrations/**.cs] section from the root .editorconfig that disabled analyzer diagnostics for migration files.
  • Added .editorconfig files with root = true and generated_code = true to three Demo migration directories (Billing, Catalog, Shipping).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.editorconfig Removed the global migration file analyzer suppression rule
src/Mocha/src/Demo/Demo.Shipping/Migrations/.editorconfig New nested .editorconfig marking migration files as generated code
src/Mocha/src/Demo/Demo.Catalog/Migrations/.editorconfig New nested .editorconfig marking migration files as generated code
src/Mocha/src/Demo/Demo.Billing/Migrations/.editorconfig New nested .editorconfig marking migration files as generated code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .editorconfig
@glen-84 glen-84 merged commit ccbc096 into main Mar 10, 2026
127 checks passed
@glen-84 glen-84 deleted the gai/mark-migrations-generated branch March 10, 2026 08:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6a3b7a3) to head (d617f39).
⚠️ Report is 932 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9346       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants