Write list values without leading or trailing spaces#9315
Conversation
Fusion Gateway Performance Results
Simple Composite Query
Response Times
Deep Recursion Query
Response Times
Variable Batching Throughput
Response Times
Runner 1 = benchmarking-1Run 22773030326 • Commit dbb74d7 • Fri, 06 Mar 2026 16:49:19 GMT |
There was a problem hiding this comment.
Pull request overview
This PR standardizes GraphQL list literal formatting across docs, tests, and serializers by removing leading/trailing spaces inside [...], aligning output like [1, 2, 3] instead of [ 1, 2, 3 ].
Changes:
- Update
SyntaxWriterExtensions.WriteListValueto stop writing spaces immediately inside list brackets. - Refresh affected snapshots/test resources/docs to match the new list formatting.
- Adjust a few inline GraphQL/JSON strings in tests/resources to reflect the updated list rendering.
Reviewed changes
Copilot reviewed 40 out of 182 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/docs/hotchocolate/v11/security/authorization.md | Updates SDL example list formatting in docs. |
| website/src/docs/hotchocolate/v12/security/authorization.md | Updates SDL example list formatting in docs. |
| website/src/docs/hotchocolate/v13/security/authorization.md | Updates SDL example list formatting in docs. |
| website/src/docs/hotchocolate/v14/security/authorization.md | Updates SDL example list formatting in docs. |
| website/src/docs/hotchocolate/v15/security/authorization.md | Updates SDL example list formatting in docs. |
| website/src/docs/hotchocolate/v16/security/authorization.md | Updates SDL example list formatting in docs. |
| src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxWriterExtensions.cs | Core behavior change: list values are written without surrounding spaces. |
| src/HotChocolate/Language/test/Language.SyntaxTree.Tests/SyntaxWriterTests.cs | Updates assertion to match new list formatting. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/JsonResultBuilderGenerator.cs | Comment example updated to match new list formatting. |
| src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/** | Snapshot/resources refreshed for new list formatting. |
| src/HotChocolate//test/ and /snapshots/ | Broad snapshot/test-string updates reflecting list formatting changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9315 +/- ##
==========================================
- Coverage 74.16% 0 -74.17%
==========================================
Files 2677 0 -2677
Lines 140790 0 -140790
Branches 16371 0 -16371
==========================================
- Hits 104421 0 -104421
+ Misses 30774 0 -30774
+ Partials 5595 0 -5595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of the changes (Less than 80 chars)