Skip to content

Write list values without leading or trailing spaces#9315

Merged
glen-84 merged 1 commit intomainfrom
gai/list-value-formatting
Mar 6, 2026
Merged

Write list values without leading or trailing spaces#9315
glen-84 merged 1 commit intomainfrom
gai/list-value-formatting

Conversation

@glen-84
Copy link
Copy Markdown
Member

@glen-84 glen-84 commented Mar 6, 2026

Summary of the changes (Less than 80 chars)

  • Write list values without leading or trailing spaces.

Copilot AI review requested due to automatic review settings March 6, 2026 16:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Fusion Gateway Performance Results

Progress: 0/6 benchmarks completed — this report updates as each job finishes.

Simple Composite Query

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Deep Recursion Query

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Variable Batching Throughput

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Runner 1 = benchmarking-1

Run 22773030326 • Commit dbb74d7 • Fri, 06 Mar 2026 16:49:19 GMT

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes GraphQL list literal formatting across docs, tests, and serializers by removing leading/trailing spaces inside [...], aligning output like [1, 2, 3] instead of [ 1, 2, 3 ].

Changes:

  • Update SyntaxWriterExtensions.WriteListValue to stop writing spaces immediately inside list brackets.
  • Refresh affected snapshots/test resources/docs to match the new list formatting.
  • Adjust a few inline GraphQL/JSON strings in tests/resources to reflect the updated list rendering.

Reviewed changes

Copilot reviewed 40 out of 182 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/src/docs/hotchocolate/v11/security/authorization.md Updates SDL example list formatting in docs.
website/src/docs/hotchocolate/v12/security/authorization.md Updates SDL example list formatting in docs.
website/src/docs/hotchocolate/v13/security/authorization.md Updates SDL example list formatting in docs.
website/src/docs/hotchocolate/v14/security/authorization.md Updates SDL example list formatting in docs.
website/src/docs/hotchocolate/v15/security/authorization.md Updates SDL example list formatting in docs.
website/src/docs/hotchocolate/v16/security/authorization.md Updates SDL example list formatting in docs.
src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxWriterExtensions.cs Core behavior change: list values are written without surrounding spaces.
src/HotChocolate/Language/test/Language.SyntaxTree.Tests/SyntaxWriterTests.cs Updates assertion to match new list formatting.
src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/JsonResultBuilderGenerator.cs Comment example updated to match new list formatting.
src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/** Snapshot/resources refreshed for new list formatting.
src/HotChocolate//test/ and /snapshots/ Broad snapshot/test-string updates reflecting list formatting changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84 glen-84 merged commit d6656a6 into main Mar 6, 2026
128 of 134 checks passed
@glen-84 glen-84 deleted the gai/list-value-formatting branch March 6, 2026 16:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6a3b7a3) to head (a284d56).
⚠️ Report is 898 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9315       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate 🌶️ strawberry shake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants