-
-
Notifications
You must be signed in to change notification settings - Fork 803
[Fusion] Add support for merging @specifiedBy directives
#9307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...colate/Fusion-vnext/src/Fusion.Composition/DirectiveMergers/SpecifiedByDirectiveMerger.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| using System.Collections.Immutable; | ||
| using HotChocolate.Fusion.Directives; | ||
| using HotChocolate.Fusion.Extensions; | ||
| using HotChocolate.Fusion.Info; | ||
| using HotChocolate.Fusion.Options; | ||
| using HotChocolate.Types; | ||
| using HotChocolate.Types.Mutable; | ||
| using ArgumentNames = HotChocolate.Fusion.WellKnownArgumentNames; | ||
| using DirectiveNames = HotChocolate.Fusion.WellKnownDirectiveNames; | ||
|
|
||
| namespace HotChocolate.Fusion.DirectiveMergers; | ||
|
|
||
| internal class SpecifiedByDirectiveMerger(DirectiveMergeBehavior mergeBehavior) | ||
| : DirectiveMergerBase(mergeBehavior) | ||
| { | ||
| public override string DirectiveName => DirectiveNames.SpecifiedBy; | ||
|
|
||
| public override MutableDirectiveDefinition GetCanonicalDirectiveDefinition(ISchemaDefinition schema) | ||
| { | ||
| return SpecifiedByMutableDirectiveDefinition.Create(schema); | ||
| } | ||
|
|
||
| public override void MergeDirectives( | ||
| IDirectivesProvider mergedMember, | ||
| ImmutableArray<DirectivesProviderInfo> memberDefinitions, | ||
| MutableSchemaDefinition mergedSchema) | ||
| { | ||
| if (!mergedSchema.DirectiveDefinitions.TryGetDirective(DirectiveName, out var directiveDefinition)) | ||
| { | ||
| // Merged definition not found. | ||
| return; | ||
| } | ||
|
|
||
| var specifiedByDirectives = | ||
| memberDefinitions | ||
| .SelectMany(d => d.Member.Directives.Where(dir => dir.Name == DirectiveNames.SpecifiedBy)) | ||
| .Select(SpecifiedByDirective.From) | ||
| .ToArray(); | ||
|
|
||
| if (specifiedByDirectives.Length == 0) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| var specifiedByDirective = | ||
| new Directive( | ||
| directiveDefinition, | ||
| new ArgumentAssignment(ArgumentNames.Url, specifiedByDirectives[0].Url)); | ||
|
|
||
| mergedMember.AddDirective(specifiedByDirective); | ||
| } | ||
| } | ||
22 changes: 22 additions & 0 deletions
22
src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Directives/SpecifiedByDirective.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| using HotChocolate.Language; | ||
| using HotChocolate.Types; | ||
| using static HotChocolate.Fusion.Properties.CompositionResources; | ||
| using ArgumentNames = HotChocolate.Types.DirectiveNames.SpecifiedBy.Arguments; | ||
|
|
||
| namespace HotChocolate.Fusion.Directives; | ||
|
|
||
| internal sealed class SpecifiedByDirective(string url) | ||
| { | ||
| public string Url { get; } = url; | ||
|
|
||
| public static SpecifiedByDirective From(IDirective directive) | ||
| { | ||
| if (!directive.Arguments.TryGetValue(ArgumentNames.Url, out var urlArg) | ||
| || urlArg is not StringValueNode url) | ||
| { | ||
| throw new InvalidOperationException(SpecifiedByDirective_UrlArgument_Invalid); | ||
| } | ||
|
|
||
| return new SpecifiedByDirective(url.Value); | ||
| } | ||
| } |
9 changes: 9 additions & 0 deletions
9
...Chocolate/Fusion-vnext/src/Fusion.Composition/Properties/CompositionResources.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.