Conversation
Fusion Gateway Performance Results
Simple Composite Query
Response Times
Deep Recursion Query
Response Times
Variable Batching Throughput
Response Times
Runner 1 = benchmarking-1Run 22615474070 • Commit fd20f71 • Tue, 03 Mar 2026 09:04:10 GMT |
There was a problem hiding this comment.
Pull request overview
This PR focuses on resolving various analyzer warnings/errors across multiple projects (tests, CLI, and core libraries) by cleaning up unused code/usings, aligning naming/style with conventions, and applying newer C# syntax where appropriate.
Changes:
- Remove unused
usingdirectives and unused private helpers/constructors flagged by analyzers. - Apply consistent naming/style tweaks (e.g.,
s_prefix for private static fields, formatting adjustments). - Modernize a few initializations/usages (e.g., collection expressions
[], simplified type references).
Reviewed changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/StrawberryShake/Client/test/Core.Tests/Serialization/AnySerializerTests.cs | Simplifies JsonSerializer usage by relying on existing using System.Text.Json;. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionRunCommand.cs | Changes ServeMode reference (currently appears to introduce an unresolved identifier). |
| src/HotChocolate/Fusion-vnext/test/Fusion.Execution.Tests/Planning/OperationPlannerBatchingGroupIdTests.cs | Uses collection expressions and removes an unused helper method. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Execution.Tests/Execution/Clients/SourceSchemaRequestDispatcherTests.cs | Formatting-only change for property declaration. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/ActivityTestHelper.cs | Removes unused HotChocolate.Utilities using. |
| src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/v15/DemoIntegrationTests.LegacyPorted.cs | Renames endpoint field to s_graphQLEndpoint and updates usages. |
| src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/SourceSchemaErrorTests.cs | Minor formatting/style fix for array initialization spacing. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Text/Json/SourceResultDocument.cs | Removes unused System.Diagnostics using. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/FusionActivityEnricher.cs | Formatting fix in list-pattern property match spacing. |
| src/HotChocolate/Data/test/Data.Tests/QueryContextUnionProjectionTests.cs | Renames private static test data fields to s_... and updates references. |
| src/HotChocolate/Data/test/Data.Tests/Issue5528ReproTests.cs | Renames private static test data field to s_data and updates references. |
| src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/Issue7110ReproTests.cs | Removes unused System.Collections.Generic using. |
| src/HotChocolate/Data/test/Data.EntityFramework.Tests/Issue5449Tests.cs | Removes a private constructor used for EF/service injection (appears behavior-breaking). |
| src/HotChocolate/Data/test/Data.EntityFramework.Tests/IntegrationTests.cs | Removes constructors used for DbContext injection in entity test (appears behavior-breaking). |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionScalarHandler.cs | Removes unused System.Linq using and minor local typing simplification. |
| src/HotChocolate/Core/test/Types.Tests/Types/Scalars/Issue6197ReproTests.cs | Removes unused System.Text.Json.Serialization using. |
| src/HotChocolate/Core/test/Types.Mutations.Tests/Issue6605ReproTests.cs | Removes unused HotChocolate.Tests using. |
| src/HotChocolate/Core/src/Types/Utilities/JsonElementTypeChangeProvider.cs | Removes unused System.Collections using. |
| src/HotChocolate/Core/src/Types/Types/Scalars/Scalars.cs | Removes unused System.Collections using. |
| src/HotChocolate/Core/src/Types/Fetching/BatchDispatcher.cs | Removes unused HotChocolate.Utilities using. |
| src/HotChocolate/Core/src/Types/Execution/Processing/Tasks/ResolverTask.cs | Removes unused HotChocolate.Utilities using. |
| src/HotChocolate/Core/src/Types.Analyzers/Inspectors/ClassBaseClassInspector.cs | Adjusts using static usage and StartsWith comparison to fix analyzer issues. |
| src/HotChocolate/Core/src/Subscriptions/DefaultTopic.cs | Removes unused HotChocolate.Utilities using. |
| src/HotChocolate/Core/src/Subscriptions.Postgres/ContinuousTask.cs | Removes unused HotChocolate.Utilities using (and blank line). |
| src/HotChocolate/AspNetCore/src/Transport.Sockets.Client/Protocols/GraphQLOverWebSocket/GraphQLOverWebSocketProtocolHandler.cs | Removes unused HotChocolate.Utilities using. |
| src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Subscriptions/OperationSession.cs | Removes unused HotChocolate.Utilities using. |
| src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Issue8756ReproTests.cs | Removes unused HotChocolate.ApolloFederation.Types using. |
Comments suppressed due to low confidence (2)
src/HotChocolate/Data/test/Data.EntityFramework.Tests/Issue5449Tests.cs:100
- The
_contextfield is never assigned anymore (the constructor that acceptedIssue5449Contextwas removed), soContextInjectedwill always befalse. That breaks what this test is asserting (entity service injection during materialization). Re-introduce the constructor used for EF Core service injection (or update the entity/service injection mechanism so_contextis set during materialization).
public sealed class Issue5449Blog
{
private readonly Issue5449Context? _context;
public Issue5449Blog()
{
Name = string.Empty;
}
public Issue5449Blog(string name)
{
Name = name;
}
public int Id { get; set; }
public string Name { get; set; }
[NotMapped]
public bool ContextInjected => _context is not null;
}
src/HotChocolate/Data/test/Data.EntityFramework.Tests/IntegrationTests.cs:684
ConstructorInjectionBlog.Contextcan no longer be set (the constructor that acceptedConstructorInjectionDbContextwas removed and the property is getter-only), soPostCountwill always evaluate to 0. This undermines the purpose ofAsSelector_Should_Preserve_Entity_Constructor_DbContext_Injection()and should cause the assertions to fail. Restore the constructor-based DbContext injection (or change the pattern so EF can populateContextduring entity materialization).
public class ConstructorInjectionBlog
{
private ConstructorInjectionDbContext? Context { get; }
public int Id { get; set; }
public string Name { get; set; } = default!;
public int PostCount => Context?.Posts.Count() ?? 0;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9292 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of the changes (Less than 80 chars)