Skip to content

Fix #7399 avoid @cost inflation for pure AddParameterExpressionBuilder injections#9267

Merged
michaelstaib merged 3 commits intomainfrom
mst/issue-7399
Mar 4, 2026
Merged

Fix #7399 avoid @cost inflation for pure AddParameterExpressionBuilder injections#9267
michaelstaib merged 3 commits intomainfrom
mst/issue-7399

Conversation

@michaelstaib
Copy link
Copy Markdown
Member

@michaelstaib michaelstaib commented Feb 27, 2026

  • adds a regression test for AddParameterExpressionBuilder + global state injection that previously auto-injected @cost(weight: "10")
  • makes CustomParameterExpressionBuilder purity configurable and defaults it to pure
  • extends AddParameterExpressionBuilder to accept an isPure flag and uses the pure default for lambda-based custom parameter expressions

Fixes #7399

@github-actions
Copy link
Copy Markdown
Contributor

Fusion Gateway Performance Results

Progress: 0/6 benchmarks completed — this report updates as each job finishes.

Simple Composite Query

Req/s Err%
Constant 2 (50 VUs) pending pending
Ramping 2 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 2 pending pending pending pending pending pending
Ramping 2 pending pending pending pending pending pending

Deep Recursion Query

Req/s Err%
Constant 2 (50 VUs) pending pending
Ramping 2 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 2 pending pending pending pending pending pending
Ramping 2 pending pending pending pending pending pending

Variable Batching Throughput

Req/s Err%
Constant 2 (50 VUs) pending pending
Ramping 2 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 2 pending pending pending pending pending pending
Ramping 2 pending pending pending pending pending pending

Runner 2 = benchmarking-2

Run 22501105240 • Commit 088d59e • Fri, 27 Feb 2026 19:41:30 GMT

@michaelstaib michaelstaib self-assigned this Mar 3, 2026
@michaelstaib michaelstaib added the 🔍 investigate Indicates that an issue or pull request needs more information. label Mar 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6a3b7a3) to head (860874d).
⚠️ Report is 864 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9267       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaelstaib michaelstaib added 🎬 ready Ready to merge and removed 🔍 investigate Indicates that an issue or pull request needs more information. labels Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect @cost when auto-injecting global state with AddParameterExpressionBuilder

1 participant