Skip to content

Rename benchmark runners and fix cancellation #9221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 2 commits into from
Feb 25, 2026
Merged

Rename benchmark runners and fix cancellation #9221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b9e97f
Rename benchmark runner groups and fix workflow cancellation
michaelstaib Feb 25, 2026
5011216
Disable benchmarking-1 runner group
michaelstaib Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 18 additions & 23 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,11 @@ jobs:
{ key: 'ramping', label: 'Ramping', desc: '(0-500-0 VUs)' },
];
const runners = [
{ group: 'Benchmarking', label: '1' },
{ group: 'Benchmarking-2', label: '2' },
{ group: 'benchmarking-2', label: '2' },
];

let md = '### Fusion Gateway Performance Results\n\n';
md += `> **Progress: 0/12 benchmarks completed** — this report updates as each job finishes.\n\n`;
md += `> **Progress: 0/6 benchmarks completed** — this report updates as each job finishes.\n\n`;

for (const test of tests) {
md += `#### ${test.title}\n\n`;
Expand All @@ -73,7 +72,7 @@ jobs:
}
md += '\n</details>\n\n---\n\n';
}
md += '*Runner 1 = Benchmarking, Runner 2 = Benchmarking-2*';
md += '*Runner 2 = benchmarking-2*';

const encodedData = Buffer.from(JSON.stringify({})).toString('base64');
const timestamp = new Date().toUTCString();
Expand Down Expand Up @@ -111,7 +110,7 @@ jobs:
benchmark:
name: "${{ matrix.test-name }} ${{ matrix.mode-label }} (${{ matrix.runner-label }})"
needs: [setup]
if: always() && (github.event_name == 'push' || github.event.pull_request.draft == false)
if: "!cancelled() && (github.event_name == 'push' || github.event.pull_request.draft == false)"
runs-on:
group: ${{ matrix.runner-group }}
permissions:
Expand All @@ -122,11 +121,9 @@ jobs:
matrix:
test: [no-recursion, deep-recursion, variable-batch]
mode: [constant, ramping]
runner-group: [Benchmarking, Benchmarking-2]
runner-group: [benchmarking-2]
include:
- runner-group: Benchmarking
runner-label: "Runner 1"
- runner-group: Benchmarking-2
- runner-group: benchmarking-2
runner-label: "Runner 2"
- test: no-recursion
test-name: "Simple Composite Query"
Expand Down Expand Up @@ -265,13 +262,12 @@ jobs:
{ key: 'ramping', label: 'Ramping', desc: '(0-500-0 VUs)' },
];
const runners = [
{ group: 'Benchmarking', label: '1' },
{ group: 'Benchmarking-2', label: '2' },
{ group: 'benchmarking-2', label: '2' },
];

let md = '### Fusion Gateway Performance Results\n\n';
if (completed < 12) {
md += `> **Progress: ${completed}/12 benchmarks completed** — this report updates as each job finishes.\n\n`;
if (completed < 6) {
md += `> **Progress: ${completed}/6 benchmarks completed** — this report updates as each job finishes.\n\n`;
}

for (const test of tests) {
Expand Down Expand Up @@ -306,7 +302,7 @@ jobs:
}
md += '\n</details>\n\n---\n\n';
}
md += '*Runner 1 = Benchmarking, Runner 2 = Benchmarking-2*';
md += '*Runner 2 = benchmarking-2*';

// Build comment body with hidden data block
const encodedData = Buffer.from(JSON.stringify(allResults)).toString('base64');
Expand All @@ -330,12 +326,12 @@ jobs:
comment_id: existing.id,
body: commentBody,
});
console.log(`Updated comment (${completed}/12 completed)`);
console.log(`Updated comment (${completed}/6 completed)`);

report:
name: "Final Performance Report"
needs: [setup, benchmark]
if: always() && github.event_name == 'pull_request'
if: "!cancelled() && github.event_name == 'pull_request'"
runs-on: ubuntu-latest
permissions:
pull-requests: write
Expand Down Expand Up @@ -436,13 +432,12 @@ jobs:
{ key: 'ramping', label: 'Ramping', desc: '(0-500-0 VUs)' },
];
const runners = [
{ group: 'Benchmarking', label: '1' },
{ group: 'Benchmarking-2', label: '2' },
{ group: 'benchmarking-2', label: '2' },
];

let md = '### Fusion Gateway Performance Results\n\n';
if (completed < 12) {
md += `> **Progress: ${completed}/12 benchmarks completed** — this report updates as each job finishes.\n\n`;
if (completed < 6) {
md += `> **Progress: ${completed}/6 benchmarks completed** — this report updates as each job finishes.\n\n`;
}

for (const test of tests) {
Expand Down Expand Up @@ -477,7 +472,7 @@ jobs:
}
md += '\n</details>\n\n---\n\n';
}
md += '*Runner 1 = Benchmarking, Runner 2 = Benchmarking-2*';
md += '*Runner 2 = benchmarking-2*';

// Build comment body
const encodedData = Buffer.from(JSON.stringify(allResults)).toString('base64');
Expand All @@ -502,15 +497,15 @@ jobs:
comment_id: existing.id,
body: commentBody,
});
console.log(`Updated final report (${completed}/12 completed)`);
console.log(`Updated final report (${completed}/6 completed)`);
} else {
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
body: commentBody,
});
console.log(`Created final report (${completed}/12 completed)`);
console.log(`Created final report (${completed}/6 completed)`);
}

store-results:
Expand Down
Loading