Fix node extension resolvers with non-id first parameter#9194
Merged
michaelstaib merged 2 commits intomainfrom Feb 24, 2026
Merged
Fix node extension resolvers with non-id first parameter#9194michaelstaib merged 2 commits intomainfrom
michaelstaib merged 2 commits intomainfrom
Conversation
1 task
Contributor
Fusion Gateway Performance ResultsSimple Composite Query
Response Times & Query
query TestQuery {
topProducts(first: 5) {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
}
}
}
}Deep Recursion Query
Response Times & Query
query TestQuery {
users {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
}
}
}
}
}
}
}
topProducts(first: 5) {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
}
}
}
}
}
}Variable Batching Throughput
Response Times & Query
query TestQuery($upc: ID!, $price: Long!, $weight: Long!) {
productByUpc(upc: $upc) {
inStock
shippingEstimate(weight: $weight, price: $price)
}
}Variables (5 sets batched per request) [
{ "upc": "1", "price": 899, "weight": 100 },
{ "upc": "2", "price": 1299, "weight": 1000 },
{ "upc": "3", "price": 15, "weight": 20 },
{ "upc": "4", "price": 499, "weight": 100 },
{ "upc": "5", "price": 1299, "weight": 1000 }
]Run 22373192883 • Commit 0f0f004 • Wed, 25 Feb 2026 01:30:27 GMT |
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
[Node]extension resolvers when the first resolver parameter is not namedidid-name behavior intact and only apply fallback when no explicitidparameter existsnode(id: ...)executing a[NodeResolver]method withuserIdWhy
id#4522 on currentmainValidation
dotnet test src/HotChocolate/Core/test/Types.Tests/HotChocolate.Types.Tests.csproj --filter "FullyQualifiedName~NodeResolverTests.NodeAttribute_On_Extension_Fetch_Through_Node_Field_With_NonId_Argument_Name" --nologodotnet test src/HotChocolate/Core/test/Types.Tests/HotChocolate.Types.Tests.csproj --filter "FullyQualifiedName~NodeTypeTests.Infer_Node_From_Query_Field_With_Abc_Argument_Resolve_" --nologodotnet test src/HotChocolate/Core/test/Types.Tests/HotChocolate.Types.Tests.csproj --filter "FullyQualifiedName~NodeResolverTests.NodeResolver_And_AsSelector" --nologo