Align built-in scalar descriptions with the spec#9180
Merged
Conversation
github-actions
Bot
added
📚 documentation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the built-in GraphQL scalar descriptions (and corresponding test fixtures/docs) to match the current spec wording, ensuring introspection outputs and docs remain consistent across HotChocolate and Strawberry Shake.
Changes:
- Updated built-in scalar descriptions for
String,Int,ID, andFloat(including the IEEE 754 link + wording tweaks). - Regenerated/updated introspection-related snapshots and test resource JSON to reflect the new descriptions.
- Updated Strawberry Shake v16 scalar documentation to match the new spec-aligned descriptions.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/docs/strawberryshake/v16/scalars.md | Updates scalar description text (and table formatting) to spec-aligned wording. |
| src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/Integration/snapshots/StarWarsIntrospectionTest.Execute_StarWarsIntrospection_Test.snap | Updates expected introspection snapshot descriptions for built-in scalars. |
| src/HotChocolate/Utilities/test/Utilities.Introspection.Tests/snapshots/IntrospectionFormatterTests.DeserializeStarWarsIntrospectionResult.snap | Updates expected SDL snapshot descriptions for built-in scalars. |
| src/HotChocolate/Utilities/test/Utilities.Introspection.Tests/resources/StarWarsIntrospectionResult.json | Updates stored introspection JSON resource descriptions for built-in scalars. |
| src/HotChocolate/Core/test/Validation.Tests/snapshots/InputObjectRequiredFieldsRuleTests.InvalidInputObjectPartialObjectMissingRequired.snap | Updates expected schema snapshot string scalar description. |
| src/HotChocolate/Core/test/Types.Tests/snapshots/SchemaFirstTests.Interfaces_Impl_Interfaces_Are_Correctly_Exposed_Through_Introspection.snap | Updates expected introspection snapshot string scalar description. |
| src/HotChocolate/Core/test/Types.Tests/snapshots/SchemaFirstTests.DescriptionsAreCorrectlyRead.snap | Updates expected introspection snapshot string scalar description. |
| src/HotChocolate/Core/test/Execution.Tests/snapshots/IntrospectionTests.ExecuteGraphiQLIntrospectionQuery_ToJson.snap | Updates expected introspection JSON snapshot string scalar description. |
| src/HotChocolate/Core/test/Execution.Tests/snapshots/IntrospectionTests.ExecuteGraphiQLIntrospectionQuery.snap | Updates expected introspection snapshot string scalar description. |
| src/HotChocolate/Core/test/Execution.Tests/snapshots/IntrospectionTests.DefaultValueIsInputObject.snap | Updates expected introspection snapshot string scalar description. |
| src/HotChocolate/Core/test/Execution.Tests/Integration/StarWarsCodeFirst/snapshots/StarWarsCodeFirstTests.Ensure_Benchmark_Query_LargeQuery.snap | Updates expected introspection snapshot descriptions for built-in scalars. |
| src/HotChocolate/Core/src/Types/Properties/TypeResources.resx | Updates localized built-in scalar description strings (source of runtime descriptions). |
| src/HotChocolate/Core/src/Types/Properties/TypeResources.Designer.cs | Updates generated strongly-typed resource accessor doc comments to match resx changes. |
Files not reviewed (1)
- src/HotChocolate/Core/src/Types/Properties/TypeResources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Fusion Gateway Performance ResultsSimple Composite Query
Response Times & Query
query TestQuery {
topProducts(first: 5) {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
}
}
}
}Deep Recursion Query
Response Times & Query
query TestQuery {
users {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
}
}
}
}
}
}
}
topProducts(first: 5) {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
}
}
}
}
}
}Variable Batching Throughput
Response Times & Query
query TestQuery($upc: ID!, $price: Long!, $weight: Long!) {
productByUpc(upc: $upc) {
inStock
shippingEstimate(weight: $weight, price: $price)
}
}Variables (5 sets batched per request) [
{ "upc": "1", "price": 899, "weight": 100 },
{ "upc": "2", "price": 1299, "weight": 1000 },
{ "upc": "3", "price": 15, "weight": 20 },
{ "upc": "4", "price": 499, "weight": 100 },
{ "upc": "5", "price": 1299, "weight": 1000 }
]Run 22340556394 • Commit 2e2eca8 • Tue, 24 Feb 2026 07:32:02 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)