Skip to content

[Nitro CLI] Hide Subgraph options#9173

Merged
tobias-tengler merged 2 commits intomainfrom
tte/hide-subgraph-options
Feb 22, 2026
Merged

[Nitro CLI] Hide Subgraph options#9173
tobias-tengler merged 2 commits intomainfrom
tte/hide-subgraph-options

Conversation

@tobias-tengler
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings February 22, 2026 09:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hides subgraph-related command-line options from the Nitro CLI help output by refactoring the option classes and adding the IsHidden = true property. The changes remove unused base classes and simplify the implementation of optional subgraph options.

Changes:

  • Deleted unused base classes SubgraphNameOption and SubgraphIdOption that were never directly referenced in the codebase
  • Refactored OptionalSubgraphNameOption and OptionalSubgraphIdOption to directly inherit from Option<string> instead of from base classes
  • Added IsHidden = true to both optional variants to hide them from CLI help output

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File Description
SubgraphName.cs Deleted file containing unused base class and optional variant
SubgraphIdOption.cs Deleted file containing unused base class and optional variant
OptionalSubgraphNameOption.cs New file with simplified implementation directly inheriting from Option and marked as hidden
OptionalSubgraphIdOption.cs New file with simplified implementation directly inheriting from Option and marked as hidden

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tobias-tengler tobias-tengler merged commit d6e068a into main Feb 22, 2026
117 checks passed
@tobias-tengler tobias-tengler deleted the tte/hide-subgraph-options branch February 22, 2026 09:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (eb20f1a) to head (9288589).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #9173   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Fusion Gateway Performance Results

Simple Composite Query

Req/s Err%
Constant (50 VUs) 2899.63 0.00%
Ramping (0-500-0 VUs) 3153.81 0.00%
Response Times & Query
Min Med Avg P90 P95 Max
Constant 0.79ms 15.09ms 17.02ms 31.09ms 36.58ms 173.13ms
Ramping 0.69ms 68.12ms 70.73ms 133.31ms 151.29ms 259.62ms
query TestQuery {
  topProducts(first: 5) {
    inStock
    name
    price
    shippingEstimate
    upc
    weight
    reviews {
      id
      body
      author {
        id
        username
        name
      }
    }
  }
}

Deep Recursion Query

Req/s Err%
Constant (50 VUs) 748.31 0.00%
Ramping (0-500-0 VUs) 830.14 0.00%
Response Times & Query
Min Med Avg P90 P95 Max
Constant 8.99ms 62.80ms 65.25ms 80.95ms 88.76ms 375.25ms
Ramping 1.82ms 257.48ms 259.33ms 509.97ms 546.15ms 686.05ms
query TestQuery {
  users {
    id
    username
    name
    reviews {
      id
      body
      product {
        inStock
        name
        price
        shippingEstimate
        upc
        weight
        reviews {
          id
          body
          author {
            id
            username
            name
            reviews {
              id
              body
              product {
                inStock
                name
                price
                shippingEstimate
                upc
                weight
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    inStock
    name
    price
    shippingEstimate
    upc
    weight
    reviews {
      id
      body
      author {
        id
        username
        name
        reviews {
          id
          body
          product {
            inStock
            name
            price
            shippingEstimate
            upc
            weight
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Req/s Err%
Constant (50 VUs) 23523.04 0.00%
Ramping (0-500-0 VUs) 18443.61 0.00%
Response Times & Query
Min Med Avg P90 P95 Max
Constant 0.10ms 1.72ms 2.08ms 3.95ms 4.84ms 51.42ms
Ramping 0.10ms 9.43ms 11.40ms 23.47ms 28.20ms 111.83ms
query TestQuery($upc: ID!, $price: Long!, $weight: Long!) {
  productByUpc(upc: $upc) {
    inStock
    shippingEstimate(weight: $weight, price: $price)
  }
}

Variables (5 sets batched per request)

[
  { "upc": "1", "price": 899, "weight": 100 },
  { "upc": "2", "price": 1299, "weight": 1000 },
  { "upc": "3", "price": 15, "weight": 20 },
  { "upc": "4", "price": 499, "weight": 100 },
  { "upc": "5", "price": 1299, "weight": 1000 }
]

Run 22274531832 • Commit 108e2bc • Sun, 22 Feb 2026 09:48:43 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants