[Nitro CLI] Hide Subgraph options#9173
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hides subgraph-related command-line options from the Nitro CLI help output by refactoring the option classes and adding the IsHidden = true property. The changes remove unused base classes and simplify the implementation of optional subgraph options.
Changes:
- Deleted unused base classes
SubgraphNameOptionandSubgraphIdOptionthat were never directly referenced in the codebase - Refactored
OptionalSubgraphNameOptionandOptionalSubgraphIdOptionto directly inherit fromOption<string>instead of from base classes - Added
IsHidden = trueto both optional variants to hide them from CLI help output
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SubgraphName.cs | Deleted file containing unused base class and optional variant |
| SubgraphIdOption.cs | Deleted file containing unused base class and optional variant |
| OptionalSubgraphNameOption.cs | New file with simplified implementation directly inheriting from Option and marked as hidden |
| OptionalSubgraphIdOption.cs | New file with simplified implementation directly inheriting from Option and marked as hidden |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9173 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fusion Gateway Performance ResultsSimple Composite Query
Response Times & Query
query TestQuery {
topProducts(first: 5) {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
}
}
}
}Deep Recursion Query
Response Times & Query
query TestQuery {
users {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
}
}
}
}
}
}
}
topProducts(first: 5) {
inStock
name
price
shippingEstimate
upc
weight
reviews {
id
body
author {
id
username
name
reviews {
id
body
product {
inStock
name
price
shippingEstimate
upc
weight
}
}
}
}
}
}Variable Batching Throughput
Response Times & Query
query TestQuery($upc: ID!, $price: Long!, $weight: Long!) {
productByUpc(upc: $upc) {
inStock
shippingEstimate(weight: $weight, price: $price)
}
}Variables (5 sets batched per request) [
{ "upc": "1", "price": 899, "weight": 100 },
{ "upc": "2", "price": 1299, "weight": 1000 },
{ "upc": "3", "price": 15, "weight": 20 },
{ "upc": "4", "price": 499, "weight": 100 },
{ "upc": "5", "price": 1299, "weight": 1000 }
]Run 22274531832 • Commit 108e2bc • Sun, 22 Feb 2026 09:48:43 GMT |
No description provided.