-
-
Notifications
You must be signed in to change notification settings - Fork 803
Add precision options to DateTime/LocalDateTime/LocalTime scalars #9167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9a0d1f3
Add precision options to DateTime/LocalDateTime/LocalTime scalars
glen-84 387e8eb
Address Copilot feedback
glen-84 a0a7d17
Update test cases
glen-84 06330ca
Merge branch 'main' into gai/date-time-precision
glen-84 793abeb
Merge branch 'main' into gai/date-time-precision
glen-84 aad8f82
Add ValidateInputFormat option
glen-84 d4c5d53
Merge branch 'main' into gai/date-time-precision
glen-84 e2ced9e
Update options summary
glen-84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -171,6 +171,7 @@ sortings | |
| Specwise | ||
| sqft | ||
| srid | ||
| sszzz | ||
| Staib | ||
| Starships | ||
| starwars | ||
|
|
||
18 changes: 18 additions & 0 deletions
18
src/HotChocolate/Core/src/Types/Properties/TypeResources.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
src/HotChocolate/Core/src/Types/Types/Scalars/DateTimeOptions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| using HotChocolate.Properties; | ||
|
|
||
| namespace HotChocolate.Types; | ||
|
|
||
| /// <summary> | ||
| /// Defines options for configuring the behavior of date and time scalar types, such as | ||
| /// <c>DateTime</c>, <c>LocalDateTime</c>, and <c>LocalTime</c>. | ||
| /// </summary> | ||
| public struct DateTimeOptions | ||
| { | ||
| public const byte DefaultInputPrecision = 7; | ||
| public const byte DefaultOutputPrecision = 7; | ||
|
|
||
| public DateTimeOptions() | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets the maximum number of fractional second digits to expect when parsing date and time | ||
| /// input values. | ||
| /// </summary> | ||
| /// <exception cref="ArgumentOutOfRangeException"> | ||
| /// Thrown when the value is greater than 7. | ||
| /// </exception> | ||
| public byte InputPrecision | ||
| { | ||
| get; | ||
| init | ||
| { | ||
| if (value > 7) | ||
| { | ||
| throw new ArgumentOutOfRangeException( | ||
| nameof(InputPrecision), | ||
| value, | ||
| TypeResources.DateTimeOptions_InputPrecision_InvalidValue); | ||
| } | ||
|
|
||
| field = value; | ||
| } | ||
| } = DefaultInputPrecision; | ||
|
|
||
| /// <summary> | ||
| /// Gets the maximum number of fractional second digits to include when serializing date and | ||
| /// time output values. | ||
| /// </summary> | ||
| /// <exception cref="ArgumentOutOfRangeException"> | ||
| /// Thrown when the value is greater than 7. | ||
| /// </exception> | ||
| public byte OutputPrecision | ||
| { | ||
| get; | ||
| init | ||
| { | ||
| if (value > 7) | ||
| { | ||
| throw new ArgumentOutOfRangeException( | ||
| nameof(OutputPrecision), | ||
| value, | ||
| TypeResources.DateTimeOptions_OutputPrecision_InvalidValue); | ||
| } | ||
|
|
||
| field = value; | ||
| } | ||
| } = DefaultOutputPrecision; | ||
|
|
||
| /// <summary> | ||
| /// Gets a value indicating whether the input format of date and time values should be validated | ||
| /// against the expected format. Defaults to <c>true</c>. | ||
| /// </summary> | ||
| public bool ValidateInputFormat { get; init; } = true; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.