Updated OneOf docs and removed unnecessary EnableOneOf code#9130
Updated OneOf docs and removed unnecessary EnableOneOf code#9130
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the OneOf documentation and removes unnecessary EnableOneOf configuration code throughout the codebase. The changes reflect that OneOf is no longer an experimental feature and is now enabled by default in HotChocolate v16. The documentation has been corrected to use the proper introspection field name isOneOf instead of the incorrect oneField.
Changes:
- Corrected OneOf documentation to reflect that it's now a standard feature (enabled by default) rather than experimental
- Fixed introspection field name from
__Type.oneFieldto__Type.isOneOfin v16 documentation - Removed unnecessary
ModifyOptions(o => o.EnableOneOf = true)calls from tests and code generation utilities
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/docs/hotchocolate/v16/defining-a-schema/input-object-types.md | Updated OneOf documentation: corrected introspection field name to isOneOf, removed experimental warning, removed EnableOneOf configuration instructions |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Utilities/SchemaHelper.cs | Removed redundant EnableOneOf = true setting in schema configuration |
| src/HotChocolate/Core/test/Validation.Tests/ValidationUtils.cs | Removed redundant EnableOneOf = true from test schema setup |
| src/HotChocolate/Core/test/Validation.Tests/DocumentValidatorVisitorTestBase.cs | Removed redundant EnableOneOf = true from test schema setup |
| src/HotChocolate/Core/test/Types.Tests/Types/OneOfIntegrationTests.cs | Removed redundant EnableOneOf = true from 30+ test methods |
| src/HotChocolate/Core/test/Types.Tests/Configuration/Validation/TypeValidationTestBase.cs | Removed redundant EnableOneOf = true from test schema validation methods |
| src/HotChocolate/Core/src/Types/IReadOnlySchemaOptions.cs | Updated comment to reflect OneOf is no longer experimental |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚀 Fusion Gateway Performance ResultsSimple Composite QueryConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query fragment User on User {
id
username
name
}
fragment Review on Review {
id
body
}
fragment Product on Product {
inStock
name
price
shippingEstimate
upc
weight
}
query TestQuery {
topProducts(first: 5) {
...Product
reviews {
...Review
author {
...User
}
}
}
}Deep Recursion QueryConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query fragment User on User {
id
username
name
}
fragment Review on Review {
id
body
}
fragment Product on Product {
inStock
name
price
shippingEstimate
upc
weight
}
query TestQuery {
users {
...User
reviews {
...Review
product {
...Product
reviews {
...Review
author {
...User
reviews {
...Review
product {
...Product
}
}
}
}
}
}
}
topProducts(first: 5) {
...Product
reviews {
...Review
author {
...User
reviews {
...Review
product {
...Product
}
}
}
}
}
}Variable Batching ThroughputConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query query TestQuery_8f7a46ce_2(
$__fusion_1_upc: ID!
$__fusion_2_price: Long!
$__fusion_2_weight: Long!
) {
productByUpc(upc: $__fusion_1_upc) {
inStock
shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
}
}Variables (5 sets batched in single request) [
{ "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
{ "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
{ "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
{ "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
{ "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]No baseline data available for comparison. Run 22134091554 • Commit 750131a • Wed, 18 Feb 2026 09:48:38 GMT |
Summary of the changes (Less than 80 chars)