Skip to content

Updated OneOf docs and removed unnecessary EnableOneOf code#9130

Merged
glen-84 merged 1 commit intomainfrom
gai/one-of-updates
Feb 18, 2026
Merged

Updated OneOf docs and removed unnecessary EnableOneOf code#9130
glen-84 merged 1 commit intomainfrom
gai/one-of-updates

Conversation

@glen-84
Copy link
Copy Markdown
Member

@glen-84 glen-84 commented Feb 18, 2026

Summary of the changes (Less than 80 chars)

  • Updated OneOf docs and removed unnecessary EnableOneOf code.

Copilot AI review requested due to automatic review settings February 18, 2026 09:29
@github-actions github-actions Bot added 📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate 🌶️ strawberry shake labels Feb 18, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the OneOf documentation and removes unnecessary EnableOneOf configuration code throughout the codebase. The changes reflect that OneOf is no longer an experimental feature and is now enabled by default in HotChocolate v16. The documentation has been corrected to use the proper introspection field name isOneOf instead of the incorrect oneField.

Changes:

  • Corrected OneOf documentation to reflect that it's now a standard feature (enabled by default) rather than experimental
  • Fixed introspection field name from __Type.oneField to __Type.isOneOf in v16 documentation
  • Removed unnecessary ModifyOptions(o => o.EnableOneOf = true) calls from tests and code generation utilities

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/src/docs/hotchocolate/v16/defining-a-schema/input-object-types.md Updated OneOf documentation: corrected introspection field name to isOneOf, removed experimental warning, removed EnableOneOf configuration instructions
src/StrawberryShake/CodeGeneration/src/CodeGeneration/Utilities/SchemaHelper.cs Removed redundant EnableOneOf = true setting in schema configuration
src/HotChocolate/Core/test/Validation.Tests/ValidationUtils.cs Removed redundant EnableOneOf = true from test schema setup
src/HotChocolate/Core/test/Validation.Tests/DocumentValidatorVisitorTestBase.cs Removed redundant EnableOneOf = true from test schema setup
src/HotChocolate/Core/test/Types.Tests/Types/OneOfIntegrationTests.cs Removed redundant EnableOneOf = true from 30+ test methods
src/HotChocolate/Core/test/Types.Tests/Configuration/Validation/TypeValidationTestBase.cs Removed redundant EnableOneOf = true from test schema validation methods
src/HotChocolate/Core/src/Types/IReadOnlySchemaOptions.cs Updated comment to reflect OneOf is no longer experimental

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84 glen-84 merged commit ea18841 into main Feb 18, 2026
123 checks passed
@glen-84 glen-84 deleted the gai/one-of-updates branch February 18, 2026 09:37
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Fusion Gateway Performance Results

Simple Composite Query

Constant Load (50 VUs)

Requests/sec Error Rate
2900.03 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.79ms 15.25ms 173.12ms 17.01ms 31.09ms 36.11ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
3159.66 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.85ms 69.72ms 261.83ms 70.59ms 132.81ms 151.19ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
      }
    }
  }
}

Deep Recursion Query

Constant Load (50 VUs)

Requests/sec Error Rate
741.65 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
7.32ms 63.05ms 346.38ms 65.89ms 81.81ms 90.52ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
822.54 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
1.83ms 253.92ms 718.43ms 262.55ms 529.05ms 564.99ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  users {
    ...User
    reviews {
      ...Review
      product {
        ...Product
        reviews {
          ...Review
          author {
            ...User
            reviews {
              ...Review
              product {
                ...Product
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
        reviews {
          ...Review
          product {
            ...Product
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Constant Load (50 VUs)

Requests/sec Error Rate
23004.55 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.10ms 1.76ms 49.24ms 2.12ms 4.04ms 4.93ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
18431.34 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.10ms 9.53ms 105.99ms 11.54ms 23.62ms 28.59ms

Executed Query

query TestQuery_8f7a46ce_2(
  $__fusion_1_upc: ID!
  $__fusion_2_price: Long!
  $__fusion_2_weight: Long!
) {
  productByUpc(upc: $__fusion_1_upc) {
    inStock
    shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
  }
}

Variables (5 sets batched in single request)

[
  { "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
  { "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
  { "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]

No baseline data available for comparison.


Run 22134091554 • Commit 750131a • Wed, 18 Feb 2026 09:48:38 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate 🌶️ strawberry shake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants