Skip to content

Fix access modifier for OnCoerceOutputValue and OnValueToLiteral#9120

Merged
michaelstaib merged 1 commit intomainfrom
mst/scalar-contract-change
Feb 16, 2026
Merged

Fix access modifier for OnCoerceOutputValue and OnValueToLiteral#9120
michaelstaib merged 1 commit intomainfrom
mst/scalar-contract-change

Conversation

@michaelstaib
Copy link
Copy Markdown
Member

@michaelstaib michaelstaib commented Feb 16, 2026

Changes the access modifiers for OnCoerceOutputValue and OnValueToLiteral in ScalarType<T> from public to protected for consistency with ScalarType<TA, TB>

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Fusion Gateway Performance Results

Simple Composite Query

Constant Load (50 VUs)

Requests/sec Error Rate
2947.11 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.80ms 14.95ms 171.89ms 16.74ms 30.60ms 36.23ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
3250.09 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.83ms 66.12ms 266.58ms 68.61ms 128.09ms 146.05ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
      }
    }
  }
}

Deep Recursion Query

Constant Load (50 VUs)

Requests/sec Error Rate
750.21 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
9.03ms 62.03ms 341.46ms 65.11ms 80.96ms 89.39ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
810.87 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
1.84ms 252.19ms 746.37ms 265.90ms 534.75ms 575.85ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  users {
    ...User
    reviews {
      ...Review
      product {
        ...Product
        reviews {
          ...Review
          author {
            ...User
            reviews {
              ...Review
              product {
                ...Product
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
        reviews {
          ...Review
          product {
            ...Product
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Constant Load (50 VUs)

Requests/sec Error Rate
23342.95 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 1.73ms 38.48ms 2.09ms 3.98ms 4.86ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
18325.10 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.10ms 9.56ms 106.07ms 11.58ms 23.61ms 28.49ms

Executed Query

query TestQuery_8f7a46ce_2(
  $__fusion_1_upc: ID!
  $__fusion_2_price: Long!
  $__fusion_2_weight: Long!
) {
  productByUpc(upc: $__fusion_1_upc) {
    inStock
    shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
  }
}

Variables (5 sets batched in single request)

[
  { "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
  { "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
  { "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]

No baseline data available for comparison.


Run 22080268850 • Commit 5bc118d • Mon, 16 Feb 2026 23:32:24 GMT

@michaelstaib michaelstaib merged commit 14a4893 into main Feb 16, 2026
117 checks passed
@michaelstaib michaelstaib deleted the mst/scalar-contract-change branch February 16, 2026 23:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (8866251) to head (8cb39ff).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #9120   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant