Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses various C# analyzer warnings/errors across the HotChocolate/StrawberryShake/CookieCrumble codebase by simplifying calls, removing unused usings, and adjusting conditional imports.
Changes:
- Simplified feature registration and null literal usage to satisfy analyzers.
- Moved/removed
usingdirectives to eliminate unused imports and fix conditional compilation. - Updated an empty dictionary initialization to use collection expressions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/StrawberryShake/Client/src/Transport.InMemory/DependencyInjection/InMemoryClient.cs | Simplifies feature registration call to avoid redundant generic usage. |
| src/HotChocolate/Json/test/Json.Tests/JsonWriterNullIgnoreTests.cs | Removes redundant nullable cast when writing a null string value in tests. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Text/Json/JsonReaderHelper.cs | Fixes conditional compilation by scoping HotChocolate.Text.Json import under #if FUSION. |
| src/HotChocolate/Core/src/Types/Types/Introspection/__InputValue.cs | Removes an unused using directive. |
| src/HotChocolate/AspNetCore/test/AspNetCore.Tests/Subscriptions/GraphQLOverWebSocket/WebSocketProtocolTests.cs | Removes an unused using directive. |
| src/HotChocolate/AspNetCore/test/AspNetCore.Tests/Subscriptions/Apollo/WebSocketProtocolTests.cs | Removes an unused using directive. |
| src/CookieCrumble/src/CookieCrumble.HotChocolate/Formatters/ExecutionResultSnapshotValueFormatter.cs | Uses collection expression for empty dictionary initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)