Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies several regular expressions by removing redundant outer capturing groups, keeping matching behavior the same while slightly reducing regex overhead and avoiding unused group captures.
Changes:
- Removed unnecessary outer capturing groups from whitespace normalization regexes.
- Removed unnecessary outer capturing groups from several scalar validation regex patterns (RGB/RGBA/IP).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Core/src/Types/Types/Descriptors/Conventions/XmlDocumentationProvider.cs | Simplifies whitespace-detection regex by removing an unused capturing group. |
| src/HotChocolate/Core/src/Types.Scalars/RgbaType.cs | Removes redundant outer capturing group from RGBA validation pattern. |
| src/HotChocolate/Core/src/Types.Scalars/RgbType.cs | Removes redundant outer capturing group from RGB validation pattern. |
| src/HotChocolate/Core/src/Types.Scalars/IPv6Type.cs | Removes redundant outer capturing group from IPv6 validation pattern while preserving anchors. |
| src/HotChocolate/Core/src/Types.Scalars/IPv4Type.cs | Removes redundant outer capturing group from IPv4 validation pattern while preserving anchors. |
| src/HotChocolate/Core/src/Types.Analyzers/Helpers/GeneratorUtils.cs | Simplifies whitespace-detection regex by removing an unused capturing group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚀 Fusion Gateway Performance ResultsSimple Composite QueryConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query fragment User on User {
id
username
name
}
fragment Review on Review {
id
body
}
fragment Product on Product {
inStock
name
price
shippingEstimate
upc
weight
}
query TestQuery {
topProducts(first: 5) {
...Product
reviews {
...Review
author {
...User
}
}
}
}Deep Recursion QueryConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query fragment User on User {
id
username
name
}
fragment Review on Review {
id
body
}
fragment Product on Product {
inStock
name
price
shippingEstimate
upc
weight
}
query TestQuery {
users {
...User
reviews {
...Review
product {
...Product
reviews {
...Review
author {
...User
reviews {
...Review
product {
...Product
}
}
}
}
}
}
}
topProducts(first: 5) {
...Product
reviews {
...Review
author {
...User
reviews {
...Review
product {
...Product
}
}
}
}
}
}Variable Batching ThroughputConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query query TestQuery_8f7a46ce_2(
$__fusion_1_upc: ID!
$__fusion_2_price: Long!
$__fusion_2_weight: Long!
) {
productByUpc(upc: $__fusion_1_upc) {
inStock
shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
}
}Variables (5 sets batched in single request) [
{ "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
{ "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
{ "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
{ "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
{ "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]No baseline data available for comparison. Run 21816382582 • Commit 4ab4ba7 • Mon, 09 Feb 2026 07:56:27 GMT |
Summary of the changes (Less than 80 chars)