Skip to content

Fixed redundant nullable warning suppression expression#9099

Merged
glen-84 merged 2 commits intomainfrom
gai/fix-redundant-suppression
Feb 8, 2026
Merged

Fixed redundant nullable warning suppression expression#9099
glen-84 merged 2 commits intomainfrom
gai/fix-redundant-suppression

Conversation

@glen-84
Copy link
Copy Markdown
Member

@glen-84 glen-84 commented Feb 8, 2026

Summary of the changes (Less than 80 chars)

  • Fixed redundant nullable warning suppression expression.

Copilot AI review requested due to automatic review settings February 8, 2026 14:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a nullable-analysis cleanup in the MCP adapter’s DI registration code, and also updates the repository’s pinned .NET SDK version via global.json.

Changes:

  • Add a NET10_0_OR_GREATER conditional to avoid a redundant null-forgiving operator when casting the keyed service name.
  • Bump pinned .NET SDK in global.json from 10.0.100 to 10.0.102.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/HotChocolate/Adapters/src/Adapters.Mcp.Core/Extensions/ServiceCollectionExtensions.cs Uses conditional compilation to remove redundant nullable suppression on newer TFMs.
global.json Updates the pinned .NET SDK version used for builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread global.json
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2026

🚀 Fusion Gateway Performance Results

Simple Composite Query

Constant Load (50 VUs)

Requests/sec Error Rate
25136.50 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 1.61ms 40.57ms 1.94ms 3.65ms 4.53ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
19590.19 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 8.47ms 110.14ms 10.72ms 22.53ms 27.05ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
      }
    }
  }
}

Deep Recursion Query

Constant Load (50 VUs)

Requests/sec Error Rate
24580.61 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 1.64ms 39.26ms 1.99ms 3.77ms 4.62ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
19376.80 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 8.53ms 99.75ms 10.85ms 22.80ms 27.91ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  users {
    ...User
    reviews {
      ...Review
      product {
        ...Product
        reviews {
          ...Review
          author {
            ...User
            reviews {
              ...Review
              product {
                ...Product
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
        reviews {
          ...Review
          product {
            ...Product
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Constant Load (50 VUs)

Requests/sec Error Rate
27717.41 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.08ms 1.45ms 27.88ms 1.76ms 3.32ms 4.07ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
22014.85 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.08ms 7.21ms 109.16ms 9.42ms 19.93ms 24.14ms

Executed Query

query TestQuery_8f7a46ce_2(
  $__fusion_1_upc: ID!
  $__fusion_2_price: Long!
  $__fusion_2_weight: Long!
) {
  productByUpc(upc: $__fusion_1_upc) {
    inStock
    shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
  }
}

Variables (5 sets batched in single request)

[
  { "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
  { "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
  { "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]

No baseline data available for comparison.


Run 21799820880 • Commit 626adae • Sun, 08 Feb 2026 14:49:53 GMT

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2026

🚀 Fusion Gateway Performance Results

Simple Composite Query

Constant Load (50 VUs)

Requests/sec Error Rate
25140.05 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 1.61ms 42.78ms 1.94ms 3.64ms 4.53ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
19754.23 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.08ms 8.37ms 106.60ms 10.66ms 22.54ms 27.32ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
      }
    }
  }
}

Deep Recursion Query

Constant Load (50 VUs)

Requests/sec Error Rate
24490.35 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 1.65ms 44.19ms 1.99ms 3.78ms 4.66ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
19352.54 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 8.64ms 120.90ms 10.88ms 22.79ms 27.82ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  users {
    ...User
    reviews {
      ...Review
      product {
        ...Product
        reviews {
          ...Review
          author {
            ...User
            reviews {
              ...Review
              product {
                ...Product
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
        reviews {
          ...Review
          product {
            ...Product
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Constant Load (50 VUs)

Requests/sec Error Rate
27669.68 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.08ms 1.45ms 39.74ms 1.76ms 3.33ms 4.09ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
21971.53 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.08ms 7.11ms 106.14ms 9.44ms 20.15ms 24.42ms

Executed Query

query TestQuery_8f7a46ce_2(
  $__fusion_1_upc: ID!
  $__fusion_2_price: Long!
  $__fusion_2_weight: Long!
) {
  productByUpc(upc: $__fusion_1_upc) {
    inStock
    shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
  }
}

Variables (5 sets batched in single request)

[
  { "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
  { "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
  { "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]

No baseline data available for comparison.


Run 21800082307 • Commit 8a5ac9c • Sun, 08 Feb 2026 15:09:13 GMT

@glen-84 glen-84 merged commit e87928c into main Feb 8, 2026
95 of 117 checks passed
@glen-84 glen-84 deleted the gai/fix-redundant-suppression branch February 8, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants