Skip to content

[Nitro CLI] Fixed output#9078

Merged
glen-84 merged 3 commits intomainfrom
gai/fix-nitro-cli-output
Jan 30, 2026
Merged

[Nitro CLI] Fixed output#9078
glen-84 merged 3 commits intomainfrom
gai/fix-nitro-cli-output

Conversation

@glen-84
Copy link
Copy Markdown
Member

@glen-84 glen-84 commented Jan 30, 2026

Summary of the changes (Less than 80 chars)

  • [Nitro CLI] Fixed output.

Copilot AI review requested due to automatic review settings January 30, 2026 09:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes output handling in the Nitro CLI by consolidating all output to standard output (stdout) instead of splitting between stdout and stderr. The changes remove the custom console extension that provided separate error stream access and update all error output calls to use the standard output stream.

Changes:

  • Removed AnsiConsoleExtensions.cs which provided Out and Error properties on IAnsiConsole
  • Updated all error output calls from console.Error.WriteLine() to console.WriteLine()
  • Changed test assertions to check standard output instead of error output
  • Modified JsonResultFormatter to write plain strings instead of JsonText objects
  • Updated ResultCommandLineBuilderExtensions to use FindResultFor instead of GetValueForOption

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
FusionComposeCommandTests.cs Updated test assertions to check standard output instead of error stream
ResultCommandLineBuilderExtensions.cs Changed option parsing to use FindResultFor for better null handling
JsonResultFormatter.cs Simplified JSON output to write plain strings instead of JsonText
ConsoleHelpers.cs Redirected error messages from stderr to stdout
ValidateSchemaCommand.cs Changed error output to use standard output
PublishSchemaCommand.cs Changed error output to use standard output
FusionConfigurationPublishValidateCommand.cs Changed error output to use standard output
FusionValidateCommand.cs Changed error output to use standard output
FusionPublishHelpers.cs Updated composition log output to use standard output
FusionPublishCommand.cs Changed exception messages to use standard output
FusionComposeCommand.cs Redirected error messages to standard output
ValidateClientCommand.cs Changed error output to use standard output
PublishClientCommand.cs Changed error output to use standard output
CommandLineBuilderExtensions.cs Updated exception handling to use standard output
AnsiConsoleExtensions.cs Removed custom extension providing Out/Error properties

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84 glen-84 merged commit a39e9fc into main Jan 30, 2026
121 of 122 checks passed
@glen-84 glen-84 deleted the gai/fix-nitro-cli-output branch January 30, 2026 09:51
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Fusion Gateway Performance Results

Simple Composite Query

Constant Load (50 VUs)

Requests/sec Error Rate
5787.40 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.77ms 7.18ms 161.44ms 8.49ms 13.16ms 18.76ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
4631.93 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.85ms 39.14ms 253.31ms 47.89ms 106.15ms 123.28ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
      }
    }
  }
}

Deep Recursion Query

Constant Load (50 VUs)

Requests/sec Error Rate
267.03 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
12.66ms 174.88ms 739.91ms 181.51ms 228.47ms 249.79ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
303.35 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
3.05ms 678.46ms 1751.73ms 698.01ms 1402.14ms 1496.83ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  users {
    ...User
    reviews {
      ...Review
      product {
        ...Product
        reviews {
          ...Review
          author {
            ...User
            reviews {
              ...Review
              product {
                ...Product
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
        reviews {
          ...Review
          product {
            ...Product
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Constant Load (50 VUs)

Requests/sec Error Rate
23726.16 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 1.70ms 43.44ms 2.06ms 3.91ms 4.78ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
18769.38 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 9.25ms 109.34ms 11.27ms 23.28ms 28.09ms

Executed Query

query TestQuery_8f7a46ce_2(
  $__fusion_1_upc: ID!
  $__fusion_2_price: Long!
  $__fusion_2_weight: Long!
) {
  productByUpc(upc: $__fusion_1_upc) {
    inStock
    shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
  }
}

Variables (5 sets batched in single request)

[
  { "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
  { "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
  { "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]

No baseline data available for comparison.


Run 21511149162 • Commit 578d83a • Fri, 30 Jan 2026 09:52:06 GMT

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (743417f) to head (e149bd9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #9078   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants