Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes output handling in the Nitro CLI by consolidating all output to standard output (stdout) instead of splitting between stdout and stderr. The changes remove the custom console extension that provided separate error stream access and update all error output calls to use the standard output stream.
Changes:
- Removed
AnsiConsoleExtensions.cswhich providedOutandErrorproperties onIAnsiConsole - Updated all error output calls from
console.Error.WriteLine()toconsole.WriteLine() - Changed test assertions to check standard output instead of error output
- Modified
JsonResultFormatterto write plain strings instead ofJsonTextobjects - Updated
ResultCommandLineBuilderExtensionsto useFindResultForinstead ofGetValueForOption
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| FusionComposeCommandTests.cs | Updated test assertions to check standard output instead of error stream |
| ResultCommandLineBuilderExtensions.cs | Changed option parsing to use FindResultFor for better null handling |
| JsonResultFormatter.cs | Simplified JSON output to write plain strings instead of JsonText |
| ConsoleHelpers.cs | Redirected error messages from stderr to stdout |
| ValidateSchemaCommand.cs | Changed error output to use standard output |
| PublishSchemaCommand.cs | Changed error output to use standard output |
| FusionConfigurationPublishValidateCommand.cs | Changed error output to use standard output |
| FusionValidateCommand.cs | Changed error output to use standard output |
| FusionPublishHelpers.cs | Updated composition log output to use standard output |
| FusionPublishCommand.cs | Changed exception messages to use standard output |
| FusionComposeCommand.cs | Redirected error messages to standard output |
| ValidateClientCommand.cs | Changed error output to use standard output |
| PublishClientCommand.cs | Changed error output to use standard output |
| CommandLineBuilderExtensions.cs | Updated exception handling to use standard output |
| AnsiConsoleExtensions.cs | Removed custom extension providing Out/Error properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚀 Fusion Gateway Performance ResultsSimple Composite QueryConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query fragment User on User {
id
username
name
}
fragment Review on Review {
id
body
}
fragment Product on Product {
inStock
name
price
shippingEstimate
upc
weight
}
query TestQuery {
topProducts(first: 5) {
...Product
reviews {
...Review
author {
...User
}
}
}
}Deep Recursion QueryConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query fragment User on User {
id
username
name
}
fragment Review on Review {
id
body
}
fragment Product on Product {
inStock
name
price
shippingEstimate
upc
weight
}
query TestQuery {
users {
...User
reviews {
...Review
product {
...Product
reviews {
...Review
author {
...User
reviews {
...Review
product {
...Product
}
}
}
}
}
}
}
topProducts(first: 5) {
...Product
reviews {
...Review
author {
...User
reviews {
...Review
product {
...Product
}
}
}
}
}
}Variable Batching ThroughputConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query query TestQuery_8f7a46ce_2(
$__fusion_1_upc: ID!
$__fusion_2_price: Long!
$__fusion_2_weight: Long!
) {
productByUpc(upc: $__fusion_1_upc) {
inStock
shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
}
}Variables (5 sets batched in single request) [
{ "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
{ "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
{ "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
{ "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
{ "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]No baseline data available for comparison. Run 21511149162 • Commit 578d83a • Fri, 30 Jan 2026 09:52:06 GMT |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9078 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of the changes (Less than 80 chars)